Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1928223002: Try again to flip x86 Linux bots to GN. (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
Reviewers:
Nico, Michael Achenbach
CC:
chromium-reviews, Finnur
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try again to flip x86 Linux bots to GN. R=thakis@chromium.org BUG=590004, 605732 Committed: https://crrev.com/e683ff3c1ac97d565f8676c13eac00c64de0c2f4 Cr-Commit-Position: refs/heads/master@{#393920}

Patch Set 1 #

Patch Set 2 : use gold instead #

Patch Set 3 : fix more typos #

Patch Set 4 : add tests #

Patch Set 5 : remove nacl_integration, telemetry_perf_unittests, remoting_unittests #

Patch Set 6 : re-add use_gold #

Patch Set 7 : rebase #

Patch Set 8 : remove views_unittests for now #

Patch Set 9 : update #

Patch Set 10 : mergesort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -19 lines) Patch
M testing/buildbot/chromium.linux.json View 1 2 3 4 5 6 7 8 9 1 chunk +374 lines, -2 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 3 4 5 6 7 8 9 8 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928223002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928223002/180001
4 years, 7 months ago (2016-05-14 01:58:02 UTC) #2
Dirk Pranke
Mind stamping this? I don't think everything quite works on Linux32 yet, but this'll be ...
4 years, 7 months ago (2016-05-14 01:58:40 UTC) #4
Dirk Pranke
On 2016/05/14 01:58:40, Dirk Pranke wrote: > Mind stamping this? > > I don't think ...
4 years, 7 months ago (2016-05-14 01:59:34 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-14 03:10:52 UTC) #8
Nico
lgtm
4 years, 7 months ago (2016-05-16 19:03:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928223002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928223002/180001
4 years, 7 months ago (2016-05-16 19:16:53 UTC) #11
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 7 months ago (2016-05-16 21:11:29 UTC) #13
commit-bot: I haz the power
Patchset 10 (id:??) landed as https://crrev.com/e683ff3c1ac97d565f8676c13eac00c64de0c2f4 Cr-Commit-Position: refs/heads/master@{#393920}
4 years, 7 months ago (2016-05-16 21:14:22 UTC) #15
Michael Achenbach
FYI: This bot started running tests when this patch landed but three are failing: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/29008
4 years, 7 months ago (2016-05-17 15:32:13 UTC) #17
Finnur
A revert of this CL (patchset #10 id:180001) has been created in https://codereview.chromium.org/1982203004/ by finnur@chromium.org. ...
4 years, 7 months ago (2016-05-17 15:36:50 UTC) #18
Dirk Pranke
4 years, 7 months ago (2016-05-17 21:57:35 UTC) #19
Message was sent while issue was closed.
On 2016/05/17 15:36:50, Finnur wrote:
> A revert of this CL (patchset #10 id:180001) has been created in
> https://codereview.chromium.org/1982203004/ by mailto:finnur@chromium.org.
> 
> The reason for reverting is: Checking to see if the error on the Linux bot
goes
> away.
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2....

I'm not super surprised that those tests are failing. Thanks for reverting!

Powered by Google App Engine
This is Rietveld 408576698