Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1928213002: X87: [api] Expose FunctionCallbackInfo::NewTarget. (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [api] Expose FunctionCallbackInfo::NewTarget. port 306c412ce04a7c21a208e33dfce530536453c20d (r35833) original commit message: This is needed by Blink to implement the Custom Elements spec. BUG= Committed: https://crrev.com/1542e46d0d6b6c4579dd7c94f54fb72cd980f953 Cr-Commit-Position: refs/heads/master@{#35889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-04-29 01:50:53 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-04-29 02:53:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928213002/1
4 years, 7 months ago (2016-04-29 04:57:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 06:43:02 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1542e46d0d6b6c4579dd7c94f54fb72cd980f953
Cr-Commit-Position: refs/heads/master@{#35889}

Powered by Google App Engine
This is Rietveld 408576698