[es8] More spec compliant syntactic tail calls implementation.

[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a return statement the keyword is now recognized as a part of expression. Error reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so we can test both modes at the same time.

This CL also adds %GetExceptionDetails(exception) that fetches hidden |start_pos| and |end_pos| values from the exception object.

BUG=v8:4915
LOG=N

Committed: https://crrev.com/1350eb3dc9421ff274d29bc9e3b08deb59b71c6b
Cr-Commit-Position: refs/heads/master@{#36024}

[Igor Sheludko, 2016-04-29 00:43:24]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 00:43:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928203002/1

[commit-bot: I haz the power, 2016-04-29 00:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 00:46:06]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5055)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5037)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/926)

[Igor Sheludko, 2016-04-29 07:35:06]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-04-29 09:14:13]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-04-29 10:39:47]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-04-29 10:46:46]

Patchset #1 (id:60001) has been deleted

[Igor Sheludko, 2016-04-29 10:46:54]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 10:46:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928203002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928203002/80001

[Igor Sheludko, 2016-04-29 10:47:06]

ishell@chromium.org changed reviewers:
+ rossberg@chromium.org

[Igor Sheludko, 2016-04-29 10:47:06]

PTAL

[commit-bot: I haz the power, 2016-04-29 11:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 11:12:10]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-04-29 13:15:50]

Description was changed from

==========
[es8] More spec compliant syntactic tail calls implementation.

BUG=v8:4915
LOG=N
==========

to

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

BUG=v8:4915
LOG=N
==========

[rossberg, 2016-05-02 10:59:40]

Changes look okay, but I think the CL needs more quite a few more tests, with
`continue` in non-trivial cases, especially nested uses of `,`, `?:`, `&&`,
`||`. Some positive r negative tests with do-expressions also couldn't harm.

https://codereview.chromium.org/1928203002/diff/80001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/1928203002/diff/80001/src/parsing/parser-base...
src/parsing/parser-base.h:789: classifier->has_tail_call_expression()) {
I'm confused, why is it an error if it _has_ a tail call? Shouldn't it be the
other way round?

https://codereview.chromium.org/1928203002/diff/80001/src/parsing/parser-base...
src/parsing/parser-base.h:2297: ValidateTailCallExpression(classifier,
CHECK_OK);
Ah, okay, think I get it now: this is validating that it is _not_ a tial call
expression. Maybe you want to change the name.

https://codereview.chromium.org/1928203002/diff/80001/test/mjsunit/es7/syntac...
File test/mjsunit/es7/syntactic-tail-call.js (right):

https://codereview.chromium.org/1928203002/diff/80001/test/mjsunit/es7/syntac...
test/mjsunit/es7/syntactic-tail-call.js:409: : f_153([f_153, test]);
Shouldn't you need a `continue` here, too, to be equivalent to the previous
version?

[Igor Sheludko, 2016-05-04 10:04:18]

Patchset #3 (id:120001) has been deleted

[Igor Sheludko, 2016-05-04 10:04:51]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 10:04:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928203002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928203002/140001

[commit-bot: I haz the power, 2016-05-04 10:06:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 10:06:08]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/5256)
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5245)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1142)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14627)

[Igor Sheludko, 2016-05-04 10:09:08]

Description was changed from

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

BUG=v8:4915
LOG=N
==========

to

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

This CL also adds %GetMessageFromException(exception) that fetches |start_pos|
and |end_pos| values hidden in the exception object.

BUG=v8:4915
LOG=N
==========

[Igor Sheludko, 2016-05-04 10:26:30]

Description was changed from

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

This CL also adds %GetMessageFromException(exception) that fetches |start_pos|
and |end_pos| values hidden in the exception object.

BUG=v8:4915
LOG=N
==========

to

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

This CL also adds %GetExceptionDetails(exception) that fetches |start_pos| and
|end_pos| values hidden in the exception object.

BUG=v8:4915
LOG=N
==========

[Igor Sheludko, 2016-05-04 10:27:03]

Description was changed from

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

This CL also adds %GetExceptionDetails(exception) that fetches |start_pos| and
|end_pos| values hidden in the exception object.

BUG=v8:4915
LOG=N
==========

to

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

This CL also adds %GetExceptionDetails(exception) that fetches hidden
|start_pos| and |end_pos| values from the exception object.

BUG=v8:4915
LOG=N
==========

[Igor Sheludko, 2016-05-04 10:28:12]

Patchset #4 (id:160001) has been deleted

[Igor Sheludko, 2016-05-04 10:28:24]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 10:28:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928203002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928203002/180001

[Igor Sheludko, 2016-05-04 10:28:55]

Addressed comments, more tests added and more bugs fixed.
PTAL

https://codereview.chromium.org/1928203002/diff/80001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/1928203002/diff/80001/src/parsing/parser-base...
src/parsing/parser-base.h:789: classifier->has_tail_call_expression()) {
On 2016/05/02 10:59:40, rossberg wrote:
> I'm confused, why is it an error if it _has_ a tail call? Shouldn't it be the
> other way round?

Updated confusing function name.

https://codereview.chromium.org/1928203002/diff/80001/src/parsing/parser-base...
src/parsing/parser-base.h:2297: ValidateTailCallExpression(classifier,
CHECK_OK);
On 2016/05/02 10:59:40, rossberg wrote:
> Ah, okay, think I get it now: this is validating that it is _not_ a tial call
> expression. Maybe you want to change the name.

Done.

https://codereview.chromium.org/1928203002/diff/80001/test/mjsunit/es7/syntac...
File test/mjsunit/es7/syntactic-tail-call.js (right):

https://codereview.chromium.org/1928203002/diff/80001/test/mjsunit/es7/syntac...
test/mjsunit/es7/syntactic-tail-call.js:409: : f_153([f_153, test]);
On 2016/05/02 10:59:40, rossberg wrote:
> Shouldn't you need a `continue` here, too, to be equivalent to the previous
> version?

The call f([f, closure, test], true) returns true.
Whatever... Done.

[rossberg, 2016-05-04 10:45:30]

https://codereview.chromium.org/1928203002/diff/140001/test/mjsunit/es8/synta...
File test/mjsunit/es8/syntactic-tail-call-parsing.js (right):

https://codereview.chromium.org/1928203002/diff/140001/test/mjsunit/es8/synta...
test/mjsunit/es8/syntactic-tail-call-parsing.js:287: `()=>{ return continue do {
x ? foo() : bar() ; }() }`,
Wait, why is this legal? A do expression shouldn't be allowed as an argument to
continue.

https://codereview.chromium.org/1928203002/diff/140001/test/mjsunit/es8/synta...
File test/mjsunit/es8/syntactic-tail-call.js (right):

https://codereview.chromium.org/1928203002/diff/140001/test/mjsunit/es8/synta...
test/mjsunit/es8/syntactic-tail-call.js:224: // Tail calling via various
expressions.
Can you add tests where these cases nest? E.g.

a || (b && continue c())
a && (b ? continue c() : e)
a, b, c && continue d()

and such combinations?

[commit-bot: I haz the power, 2016-05-04 10:54:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 10:54:49]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-05-04 11:49:29]

Patchset #5 (id:200001) has been deleted

[Igor Sheludko, 2016-05-04 11:50:14]

https://codereview.chromium.org/1928203002/diff/140001/test/mjsunit/es8/synta...
File test/mjsunit/es8/syntactic-tail-call-parsing.js (right):

https://codereview.chromium.org/1928203002/diff/140001/test/mjsunit/es8/synta...
test/mjsunit/es8/syntactic-tail-call-parsing.js:287: `()=>{ return continue do {
x ? foo() : bar() ; }() }`,
On 2016/05/04 10:45:30, rossberg wrote:
> Wait, why is this legal? A do expression shouldn't be allowed as an argument
to
> continue.

Because it's actually a
  return continue (do {...}) ();

https://codereview.chromium.org/1928203002/diff/140001/test/mjsunit/es8/synta...
File test/mjsunit/es8/syntactic-tail-call.js (right):

https://codereview.chromium.org/1928203002/diff/140001/test/mjsunit/es8/synta...
test/mjsunit/es8/syntactic-tail-call.js:224: // Tail calling via various
expressions.
On 2016/05/04 10:45:30, rossberg wrote:
> Can you add tests where these cases nest? E.g.
> 
> a || (b && continue c())
> a && (b ? continue c() : e)
> a, b, c && continue d()
> 
> and such combinations?

Done.

[rossberg, 2016-05-04 12:09:28]

Thanks, lgtm

[Igor Sheludko, 2016-05-04 12:10:13]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-05-04 12:10:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928203002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928203002/220001

[Igor Sheludko, 2016-05-04 12:10:31]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2016-05-04 13:14:48]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-05-04 13:14:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1928203002/#ps240001
(title: "Some STC tests ported for PTC")

[commit-bot: I haz the power, 2016-05-04 13:14:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928203002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928203002/240001

[commit-bot: I haz the power, 2016-05-04 13:42:56]

Description was changed from

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

This CL also adds %GetExceptionDetails(exception) that fetches hidden
|start_pos| and |end_pos| values from the exception object.

BUG=v8:4915
LOG=N
==========

to

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

This CL also adds %GetExceptionDetails(exception) that fetches hidden
|start_pos| and |end_pos| values from the exception object.

BUG=v8:4915
LOG=N
==========

[commit-bot: I haz the power, 2016-05-04 13:42:58]

Committed patchset #6 (id:240001)

[commit-bot: I haz the power, 2016-05-04 13:44:50]

Description was changed from

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

This CL also adds %GetExceptionDetails(exception) that fetches hidden
|start_pos| and |end_pos| values from the exception object.

BUG=v8:4915
LOG=N
==========

to

==========
[es8] More spec compliant syntactic tail calls implementation.

Unlike previous implementation where the 'continue' keyword was a feature of a
return statement the keyword is now recognized as a part of expression. Error
reporting was significantly improved.

--harmony-explicit-tailcalls option is now orthogonal to --harmony-tailcalls so
we can test both modes at the same time.

This CL also adds %GetExceptionDetails(exception) that fetches hidden
|start_pos| and |end_pos| values from the exception object.

BUG=v8:4915
LOG=N

Committed: https://crrev.com/1350eb3dc9421ff274d29bc9e3b08deb59b71c6b
Cr-Commit-Position: refs/heads/master@{#36024}
==========

[commit-bot: I haz the power, 2016-05-04 13:44:51]

Patchset 6 (id:??) landed as
https://crrev.com/1350eb3dc9421ff274d29bc9e3b08deb59b71c6b
Cr-Commit-Position: refs/heads/master@{#36024}