Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 1928193002: Revert of [Extensions] Finish freezing schema (Closed)

Created:
2 years, 10 months ago by Devlin
Modified:
2 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions] Finish freezing schema (patchset #1 id:1 of https://codereview.chromium.org/1928783005/ ) Reason for revert: Compile failure Original issue's description: > [Extensions] Finish freezing schema > > BUG=604901 > BUG=603725 > BUG=591164 > > Review URL: https://codereview.chromium.org/1906593002 > > Cr-Commit-Position: refs/heads/master@{#388945} > (cherry picked from commit 5fb2548448bd1b76a59d941b729d7a7f90d53bc8) > > Committed: https://chromium.googlesource.com/chromium/src/+/ed087c3f125239baa798fbbceded413d529674ed TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=604901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -76 lines) Patch
M chrome/renderer/resources/extensions/chrome_setting.js View 2 chunks +6 lines, -18 lines 0 comments Download
M chrome/renderer/resources/extensions/content_setting.js View 2 chunks +6 lines, -17 lines 0 comments Download
M chrome/test/data/extensions/api_test/stubs_app/background.js View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/resources/binding.js View 1 chunk +1 line, -11 lines 0 comments Download
M extensions/renderer/resources/event.js View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/resources/json_schema.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/schema_utils.js View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/resources/storage_area.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/utils.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/safe_builtins.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/renderer/v8_schema_registry.cc View 2 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Devlin
Created Revert of [Extensions] Finish freezing schema
2 years, 10 months ago (2016-04-29 00:21:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928193002/1
2 years, 10 months ago (2016-04-29 00:21:57 UTC) #2
commit-bot: I haz the power
2 years, 10 months ago (2016-04-29 00:24:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698