Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp

Issue 1928163002: Add a name attribute for each AudioParam (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation error Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
index 07b2a655dd6018cf33994f51bf794ab81edd9f19..8636b518f061a1cc7f443949e779d1e406b26e5c 100644
--- a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
@@ -333,9 +333,9 @@ bool OscillatorHandler::propagatesSilence() const
OscillatorNode::OscillatorNode(AbstractAudioContext& context, float sampleRate)
: AudioScheduledSourceNode(context)
// Use musical pitch standard A440 as a default.
- , m_frequency(AudioParam::create(context, 440))
+ , m_frequency(AudioParam::create(context, ParamTypeOscillatorFrequency, 440))
// Default to no detuning.
- , m_detune(AudioParam::create(context, 0))
+ , m_detune(AudioParam::create(context, ParamTypeOscillatorDetune, 0))
{
setHandler(OscillatorHandler::create(*this, sampleRate, m_frequency->handler(), m_detune->handler()));
}

Powered by Google App Engine
This is Rietveld 408576698