Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioParam.cpp

Issue 1928163002: Add a name attribute for each AudioParam (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation error Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp b/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
index aa505aa81ac9e5770e7ea99a51041d463cbdd79e..ab6894a96fabaae33bd7554d04093c22a1489831 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
@@ -40,6 +40,49 @@ AudioDestinationHandler& AudioParamHandler::destinationHandler() const
return *m_destinationHandler;
}
+String AudioParamHandler::getParamName() const
+{
+ // The returned string should be the name of the node and the name of the AudioParam for
+ // that node.
+ switch (m_paramType) {
+ case ParamTypeAudioBufferSourcePlaybackRate:
+ return "AudioBufferSource.playbackRate";
+ case ParamTypeAudioBufferSourceDetune:
+ return "AudioBufferSource.detune";
+ case ParamTypeBiquadFilterFrequency:
+ return "BiquadFilter.frequency";
+ case ParamTypeBiquadFilterQ:
+ return "BiquadFilter.Q";
+ case ParamTypeBiquadFilterGain:
+ return "BiquadFilter.gain";
+ case ParamTypeBiquadFilterDetune:
+ return "BiquadFilter.detune";
+ case ParamTypeDelayDelayTime:
+ return "Delay.delayTime";
+ case ParamTypeDynamicsCompressorThreshold:
+ return "DynamicsCompressor.threshold";
+ case ParamTypeDynamicsCompressorKnee:
+ return "DynamicsCompressor.knee";
+ case ParamTypeDynamicsCompressorRatio:
+ return "DynamicsCompressor.ratio";
+ case ParamTypeDynamicsCompressorAttack:
+ return "DynamicsCompressor.attack";
+ case ParamTypeDynamicsCompressorRelease:
+ return "DynamicsCompressor.release";
+ case ParamTypeGainGain:
+ return "Gain.gain";
+ case ParamTypeOscillatorFrequency:
+ return "Oscillator.frequency";
+ case ParamTypeOscillatorDetune:
+ return "Oscillator.detune";
+ case ParamTypeStereoPannerPan:
+ return "StereoPanner.pan";
+ };
+
+ NOTREACHED();
+ return "UnknownNode.unknownAudioParam";
+}
+
float AudioParamHandler::value()
{
// Update value for timeline.
@@ -193,15 +236,15 @@ void AudioParamHandler::disconnect(AudioNodeOutput& output)
// ----------------------------------------------------------------
-AudioParam::AudioParam(AbstractAudioContext& context, double defaultValue)
- : m_handler(AudioParamHandler::create(context, defaultValue))
+AudioParam::AudioParam(AbstractAudioContext& context, AudioParamType paramType, double defaultValue)
+ : m_handler(AudioParamHandler::create(context, paramType, defaultValue))
, m_context(context)
{
}
-AudioParam* AudioParam::create(AbstractAudioContext& context, double defaultValue)
+AudioParam* AudioParam::create(AbstractAudioContext& context, AudioParamType paramType, double defaultValue)
{
- return new AudioParam(context, defaultValue);
+ return new AudioParam(context, paramType, defaultValue);
}
DEFINE_TRACE(AudioParam)

Powered by Google App Engine
This is Rietveld 408576698