third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp - Issue 1928163002: Add a name attribute for each AudioParam

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

Issue 1928163002: Add a name attribute for each AudioParam (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use enum instead of string Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioParam.h ('K') | « third_party/WebKit/Source/modules/webaudio/AudioParam.cpp ('k') | third_party/WebKit/Source/modules/webaudio/DelayNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

index 45a2fc7942c8be6bcb4a6a4e2517d45da67a0276..fa303d057814987fecece5106e5d7bdca15b1bf0 100644

--- a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

@@ -29,10 +29,10 @@ namespace blink {

BiquadFilterNode::BiquadFilterNode(AbstractAudioContext& context, float sampleRate)

: AudioNode(context)

- , m_frequency(AudioParam::create(context, 350.0))

- , m_q(AudioParam::create(context, 1))

- , m_gain(AudioParam::create(context, 0.0))

- , m_detune(AudioParam::create(context, 0.0))

+ , m_frequency(AudioParam::create(context, AudioParamHandler::BiquadFilterFrequency, 350.0))

+ , m_q(AudioParam::create(context, AudioParamHandler::BiquadFilterQ, 1))

+ , m_gain(AudioParam::create(context, AudioParamHandler::BiquadFilterGain, 0.0))

+ , m_detune(AudioParam::create(context, AudioParamHandler::BiquadFilterDetune, 0.0))

{

setHandler(AudioBasicProcessorHandler::create(AudioHandler::NodeTypeBiquadFilter, *this, sampleRate, adoptPtr(new BiquadProcessor(sampleRate, 1, m_frequency->handler(), m_q->handler(), m_gain->handler(), m_detune->handler()))));

}