Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1928143002: Rename gfx::Display/Screen to display::Display/Screen in chromecast/blimp/media (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
DaleCurtis, Wez, alokp
CC:
anandc+watch-blimp_chromium.org, chromium-reviews, dtrainor+watch-blimp_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lcwu+watch_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mcasas+watch+vc_chromium.org, nyquist+watch-blimp_chromium.org, posciak+watch_chromium.org, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display/Screen to display::Display/Screen in chromecast/blimp/media BUG=597761 Committed: https://crrev.com/fc9726d01ce7a5fb78f31c9a43c2d461637a3682 Cr-Commit-Position: refs/heads/master@{#390689}

Patch Set 1 : #

Patch Set 2 : update blimp's gn for recent gn change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -86 lines) Patch
M blimp/engine/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/engine/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/app/ui/blimp_screen.h View 3 chunks +15 lines, -13 lines 0 comments Download
M blimp/engine/app/ui/blimp_screen.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M blimp/engine/app/ui/blimp_screen_unittest.cc View 5 chunks +15 lines, -14 lines 0 comments Download
M blimp/engine/session/blimp_engine_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromecast/browser/cast_content_window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/graphics/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/graphics/cast_screen.h View 2 chunks +15 lines, -13 lines 0 comments Download
M chromecast/graphics/cast_screen.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M chromecast/media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/media/base/video_plane_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.h View 2 chunks +5 lines, -1 line 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.cc View 6 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 30 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928143002/1
4 years, 7 months ago (2016-04-28 20:38:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928143002/20001
4 years, 7 months ago (2016-04-28 21:12:14 UTC) #6
oshima
wez@ -> blimp alokp@ -> chromecast dalecurtis@ -> media
4 years, 7 months ago (2016-04-28 21:12:58 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/129816) chromeos_daisy_chromium_compile_only_ng on ...
4 years, 7 months ago (2016-04-28 21:18:06 UTC) #10
alokp
chromecast/ lgtm
4 years, 7 months ago (2016-04-28 21:22:14 UTC) #11
DaleCurtis
lgtm
4 years, 7 months ago (2016-04-28 22:10:01 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928143002/40001
4 years, 7 months ago (2016-04-28 22:39:20 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/220918)
4 years, 7 months ago (2016-04-29 00:35:32 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928143002/40001
4 years, 7 months ago (2016-04-29 00:39:27 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 02:21:26 UTC) #20
Wez
LGTM w/ nit. nit: CL description implies you're renaming Display vs Screen, but it looks ...
4 years, 7 months ago (2016-04-29 17:28:38 UTC) #21
oshima
On 2016/04/29 17:28:38, Wez wrote: > LGTM w/ nit. > > nit: CL description implies ...
4 years, 7 months ago (2016-04-29 17:37:01 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928143002/40001
4 years, 7 months ago (2016-04-29 17:37:57 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-04-29 17:43:13 UTC) #28
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:55 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc9726d01ce7a5fb78f31c9a43c2d461637a3682
Cr-Commit-Position: refs/heads/master@{#390689}

Powered by Google App Engine
This is Rietveld 408576698