Unify implementations of stroking radius calculations

Unify implementations of stroking radius calculationsns
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1928133002

Committed: https://skia.googlesource.com/skia/+/5668648e875abe0a064caabef432ade4745deb89

[bsalomon, 2016-04-28 20:05:27]

Description was changed from

==========
Unify implementations of stroke rec radius calculations
==========

to

==========
Unify implementations of stroke rec radius calculations
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-04-28 20:06:22]

Description was changed from

==========
Unify implementations of stroke rec radius calculations
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Unify implementations of stroking radius calculationsns
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-04-28 20:06:22]

bsalomon@google.com changed reviewers:
+ reed@google.com

[bsalomon, 2016-04-28 20:39:01]

https://codereview.chromium.org/1928133002/diff/1/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (left):

https://codereview.chromium.org/1928133002/diff/1/src/core/SkPaint.cpp#oldcod...
src/core/SkPaint.cpp:2028: if (kFill_Style != style) {
Just noticed this uses the passed in style var rather that SkPaint's fStyle.
I'll update this CL.

[bsalomon, 2016-04-28 20:49:29]

https://codereview.chromium.org/1928133002/diff/1/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (left):

https://codereview.chromium.org/1928133002/diff/1/src/core/SkPaint.cpp#oldcod...
src/core/SkPaint.cpp:2028: if (kFill_Style != style) {
On 2016/04/28 20:39:01, bsalomon wrote:
> Just noticed this uses the passed in style var rather that SkPaint's fStyle.
> I'll update this CL.

Ok, fixed that.

[reed1, 2016-04-29 00:43:34]

lgtm

https://codereview.chromium.org/1928133002/diff/20001/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

https://codereview.chromium.org/1928133002/diff/20001/src/core/SkPaint.cpp#ne...
src/core/SkPaint.cpp:2030: src->fRight + radius, src->fBottom + radius);
*storage = src->makeOutset(radius, radius);

[bsalomon, 2016-04-29 13:33:37]

https://codereview.chromium.org/1928133002/diff/20001/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

https://codereview.chromium.org/1928133002/diff/20001/src/core/SkPaint.cpp#ne...
src/core/SkPaint.cpp:2030: src->fRight + radius, src->fBottom + radius);
On 2016/04/29 00:43:34, reed1 wrote:
> *storage = src->makeOutset(radius, radius);

That function is not implemented correctly. I'll leave this as is for now and
prepare a CL to fix it.

[bsalomon, 2016-04-29 13:33:46]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-04-29 13:33:46]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1928133002/#ps60001
(title: "revert use of makeStorage")

[commit-bot: I haz the power, 2016-04-29 13:33:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928133002/60001

[bsalomon, 2016-04-29 13:34:53]

On 2016/04/29 13:33:37, bsalomon wrote:
> https://codereview.chromium.org/1928133002/diff/20001/src/core/SkPaint.cpp
> File src/core/SkPaint.cpp (right):
> 
>
https://codereview.chromium.org/1928133002/diff/20001/src/core/SkPaint.cpp#ne...
> src/core/SkPaint.cpp:2030: src->fRight + radius, src->fBottom + radius);
> On 2016/04/29 00:43:34, reed1 wrote:
> > *storage = src->makeOutset(radius, radius);
> 
> That function is not implemented correctly. I'll leave this as is for now and
> prepare a CL to fix it.

Oh n/m I was looking at makeOffset not makeOutset.

[bsalomon, 2016-04-29 13:34:58]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2016-04-29 13:37:52]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-04-29 13:37:52]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1928133002/#ps80001
(title: "use makeOutset")

[commit-bot: I haz the power, 2016-04-29 13:37:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928133002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928133002/80001

[commit-bot: I haz the power, 2016-04-29 14:07:05]

Description was changed from

==========
Unify implementations of stroking radius calculationsns
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Unify implementations of stroking radius calculationsns
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/5668648e875abe0a064caabef432ade4745deb89
==========

[commit-bot: I haz the power, 2016-04-29 14:07:06]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/5668648e875abe0a064caabef432ade4745deb89