Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Issue 1928073002: mojo leveldb: Reenable tests which can be moved to the in-memory db. (Closed)

Created:
4 years, 7 months ago by Elliot Glaysher
Modified:
4 years, 7 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo leveldb: Reenable tests which can be moved to the in-memory db. File operations were causing flake on some of the leveldb tests. We now run tests that can be done on an in-memory database there. (There's still one test left disabled which requires file operations and will be sorted out separately.) BUG=602820 Committed: https://crrev.com/cb8314f733c1d0fb260c6059245fcf6ce2036317 Cr-Commit-Position: refs/heads/master@{#390747}

Patch Set 1 #

Patch Set 2 : Reupload for another set of tryjobs. #

Patch Set 3 : Reupload for another set of tryjobs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -57 lines) Patch
M components/leveldb/leveldb_service_unittest.cc View 5 chunks +9 lines, -57 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Elliot Glaysher
I'm leaving one of the tests disabled since it will take a bit more work.
4 years, 7 months ago (2016-04-28 20:12:21 UTC) #2
Elliot Glaysher
ping michaeln
4 years, 7 months ago (2016-04-29 19:12:24 UTC) #3
michaeln
lgtm
4 years, 7 months ago (2016-04-29 20:01:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928073002/40001
4 years, 7 months ago (2016-04-29 20:02:53 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-29 20:42:26 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:28:36 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cb8314f733c1d0fb260c6059245fcf6ce2036317
Cr-Commit-Position: refs/heads/master@{#390747}

Powered by Google App Engine
This is Rietveld 408576698