chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java - Issue 1928063002: [NTP Snippets] Fill space below the last snippet if necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java

Issue 1928063002: [NTP Snippets] Fill space below the last snippet if necessary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/PaddingListItem.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/PaddingListItem.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java

index da0719b053036e8a39bf6d07e491c9fce4132696..b7713dd66ed9102f69b13a7ddc260ec0963bf37e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java

@@ -62,9 +62,11 @@ public void onDraw(Canvas c, RecyclerView parent, RecyclerView.State state) {

private boolean shouldPlaceSeparator(View view, RecyclerView parent) {

int childPos = parent.getChildAdapterPosition(view);

- Adapter adapter = parent.getAdapter();

+ Adapter<?> adapter = parent.getAdapter();

- if (childPos == adapter.getItemCount() - 1) return false;

+ if (childPos == adapter.getItemCount() - 1 || childPos == RecyclerView.NO_POSITION) {

+ return false;

+ }

return adapter.getItemViewType(childPos) == NewTabPageListItem.VIEW_TYPE_SNIPPET

&& adapter.getItemViewType(childPos + 1) == NewTabPageListItem.VIEW_TYPE_SNIPPET;