Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 1928063002: [NTP Snippets] Fill space below the last snippet if necessary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/toolbar.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/values/dimens.xml
diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml
index 23c1b8063deb08200a75ef1274763e0b4622e325..d4287ba71576135ea73d6e08436bca79c5f14702 100644
--- a/chrome/android/java/res/values/dimens.xml
+++ b/chrome/android/java/res/values/dimens.xml
@@ -223,6 +223,7 @@
<dimen name="toolbar_tab_count_text_size_1_digit">12dp</dimen>
<dimen name="toolbar_tab_count_text_size_2_digit">10dp</dimen>
<dimen name="toolbar_height_no_shadow">56dp</dimen>
+ <dimen name="toolbar_progress_bar_height">2dp</dimen>
<dimen name="toolbar_button_width">48dp</dimen>
<dimen name="location_bar_margin_top">5dp</dimen>
@@ -264,6 +265,7 @@
<dimen name="snippets_thumbnail_size">72dp</dimen>
<dimen name="snippets_padding_and_peeking_card_height">16dp</dimen>
<dimen name="snippets_vertical_spacing">1dp</dimen>
+ <dimen name="snippets_bottom_padding">40dp</dimen>
mcwilliams 2016/05/10 12:42:52 We should remove this for now as discussed
dgn 2016/05/10 14:26:12 Done.
<!-- Interests page -->
<dimen name="ntp_interest_item_text_size">20sp</dimen>
« no previous file with comments | « chrome/android/java/res/layout/toolbar.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698