Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2511)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java

Issue 1928063002: [NTP Snippets] Fill space below the last snippet if necessary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: suppress warning, back to int instead of viewlist, remove unnecessary checks Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java
index d3ede56f60e33858686266f80d4ba09ef27cf8ea..ba9e775482b6d14ef865d6771dcbd2ffb52cea58 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java
@@ -17,7 +17,7 @@
* @see Adapter#getItemViewType(int)
* @see NewTabPageListItem#getType()
*/
- @IntDef({VIEW_TYPE_ABOVE_THE_FOLD, VIEW_TYPE_HEADER, VIEW_TYPE_SNIPPET})
+ @IntDef({VIEW_TYPE_ABOVE_THE_FOLD, VIEW_TYPE_HEADER, VIEW_TYPE_SNIPPET, VIEW_TYPE_SPACING})
@Retention(RetentionPolicy.SOURCE)
public @interface ViewType {}
@@ -40,6 +40,12 @@
public static final int VIEW_TYPE_SNIPPET = 3;
/**
+ * View type for a {@link SpacingListItem} used to provide spacing at the end of the list.
+ * @see Adapter#getItemViewType(int)
+ */
+ public static final int VIEW_TYPE_SPACING = 4;
+
+ /**
* Returns the type ({@link ViewType}) of this list item. This is so we can
* distinguish between different elements that are held in a single RecyclerView holder.
*

Powered by Google App Engine
This is Rietveld 408576698