third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp - Issue 1928043002: Add drawImage() originClean() getSecurityOrigin() to OffscreenCanvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

Issue 1928043002: Add drawImage() originClean() getSecurityOrigin() to OffscreenCanvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase master and Edited based on haraken's comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp ('K') | « third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.idl ('k') | third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

diff --git a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

index 7ddd64cf5edb467a857fe0e34e754c74b403d170..d3a0401399a2a955c3358448cb6afa8290ff49ac 100644

--- a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

+++ b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

@@ -36,7 +36,8 @@ private:

TEST_F(HTMLCanvasElementModuleTest, TransferControlToOffscreen)

{

NonThrowableExceptionState exceptionState;

- OffscreenCanvas* offscreenCanvas = HTMLCanvasElementModule::transferControlToOffscreen(canvasElement(), exceptionState);

+ ExecutionContext* executionContext = canvasElement().getExecutionContext();

+ OffscreenCanvas* offscreenCanvas = HTMLCanvasElementModule::transferControlToOffscreen(executionContext, canvasElement(), exceptionState);

int canvasId = offscreenCanvas->getAssociatedCanvasId();

EXPECT_EQ(canvasId, DOMNodeIds::idForNode(&(canvasElement())));

}