Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 1928023002: Remove WebContentsDelegate::SwappedOut (Closed)

Created:
4 years, 7 months ago by nasko
Modified:
4 years, 7 months ago
Reviewers:
jam, alexmos
CC:
chromium-reviews, nasko+codewatch_chromium.org, creis+watch_chromium.org, achuith+watch_chromium.org, dzhioev+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebContentsDelegate::SwappedOut Swapped out RenderFrameHosts no longer exists and this API is not used in any meaningful way, therefore I'm removing it. BUG=357747 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/84069951a41d11c516dc06579beef14221de543e Cr-Commit-Position: refs/heads/master@{#390998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M chrome/browser/chromeos/login/ui/webui_login_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nasko
Hey John, Can you review this CL for me? It removes a content/public/ API that ...
4 years, 7 months ago (2016-04-28 18:27:00 UTC) #3
nasko
Hey Alex, Can you review this CL for me? Thanks! Nasko
4 years, 7 months ago (2016-04-30 00:16:08 UTC) #5
jam
lgtm
4 years, 7 months ago (2016-05-02 15:57:45 UTC) #6
alexmos
LGTM
4 years, 7 months ago (2016-05-02 16:10:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928023002/1
4 years, 7 months ago (2016-05-02 16:36:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 18:23:27 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 18:25:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84069951a41d11c516dc06579beef14221de543e
Cr-Commit-Position: refs/heads/master@{#390998}

Powered by Google App Engine
This is Rietveld 408576698