chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc - Issue 1928013004: Add delayed retry to DeviceManagementService requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

Issue 1928013004: Add delayed retry to DeviceManagementService requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/user_affiliation_browsertest.cc ('k') | chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

diff --git a/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc b/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

index d69fcbc14ebe6031233fc31fa1ff0ec8455f3e9b..8caae782684e3395364078cfcd3b6b1faae2111e 100644

--- a/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

+++ b/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

@@ -13,6 +13,7 @@

#include "chrome/test/base/ui_test_utils.h"

#include "chromeos/dbus/fake_session_manager_client.h"

#include "chromeos/login/user_names.h"

+#include "components/policy/core/common/cloud/device_management_service.h"

#include "components/policy/core/common/mock_configuration_policy_provider.h"

#include "components/prefs/pref_service.h"

#include "components/signin/core/account_id/account_id.h"

@@ -118,6 +119,9 @@ class EnterpriseDeviceAttributesTest :

policy_provider_.SetAutoRefresh();

policy::BrowserPolicyConnector::SetPolicyProviderForTesting(

&policy_provider_);

+ // Set retry delay to prevent timeouts

cschuet (SLOW) 2016/05/13 15:20:22 nit "." at the end.

Marton Hunyady 2016/05/13 15:27:26 Done.

+ policy::DeviceManagementService::SetRetryDelayForTesting(0);

}

void SetUpOnMainThread() override {