Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: runtime/lib/expando_patch.dart

Issue 19280006: Fix dartbug.com/11757: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/expando_patch.dart
===================================================================
--- runtime/lib/expando_patch.dart (revision 24831)
+++ runtime/lib/expando_patch.dart (working copy)
@@ -114,8 +114,14 @@
for (var i = 0; i < old_data.length; i++) {
var entry = old_data[i];
- if ((entry != null) && (entry.key != null)) {
- this[entry.key] = entry.value;
+ if (entry != null) {
+ // Ensure that the entry.key is not cleared between checking for it and
+ // inserting it into the new table.
+ var val = entry.value;
+ var key = entry.key;
+ if (key != null) {
+ this[key] = val;
+ }
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698