Remove IFDE_TxtEdt interfaces where possible.

Remove IFDE_TxtEdt interfaces where possible.

This CL removes the following and uses the only instance instead.
  * IFDE_TxtEdtParag
  * IFDE_TxtEdtEventSink
  * IFDE_TxtEdtEngine
  * IFDE_TxtEdtBuf

Committed: https://pdfium.googlesource.com/pdfium/+/b696f7d616ef397a01af1d6bd01c061922a259f7

[dsinclair, 2016-04-28 14:59:39]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-28 14:59:39]

PTAL.

https://codereview.chromium.org/1927973003/diff/1/xfa/fwl/basewidget/fwl_edit...
File xfa/fwl/basewidget/fwl_editimp.cpp (right):

https://codereview.chromium.org/1927973003/diff/1/xfa/fwl/basewidget/fwl_edit...
xfa/fwl/basewidget/fwl_editimp.cpp:756: FDE_TXTEDTPARAMS* pParams =
m_pEdtEngine->GetEditParams();
The cast was casting away the const. I removed the const from the method to make
it clear we could edit the result.

[Tom Sepez, 2016-04-28 16:51:09]

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtbuf.h
File xfa/fee/fde_txtedtbuf.h (right):

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtbuf.h#new...
xfa/fee/fde_txtedtbuf.h:13: #define FDE_DEFCHUNKLENGTH (1024)
nit: why ()?

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtbuf.h#new...
xfa/fee/fde_txtedtbuf.h:53: int32_t nCount = -1) const;
nit: sp. nBegin

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtbuf.h#new...
xfa/fee/fde_txtedtbuf.h:59: FX_BOOL Optimize(IFX_Pause* pPause = NULL);
nit: nullptr

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtparag.h
File xfa/fee/fde_txtedtparag.h (right):

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtparag.h#n...
xfa/fee/fde_txtedtparag.h:27: int32_t m_nCharStart;
can these be private given the Get* methods above?

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/ifde_txtedtengine.h
File xfa/fee/ifde_txtedtengine.h (right):

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/ifde_txtedtengine.h...
xfa/fee/ifde_txtedtengine.h:94: pFont(NULL),
nit: nullptr (also below)

https://codereview.chromium.org/1927973003/diff/1/xfa/fwl/basewidget/fwl_edit...
File xfa/fwl/basewidget/fwl_editimp.cpp (right):

https://codereview.chromium.org/1927973003/diff/1/xfa/fwl/basewidget/fwl_edit...
xfa/fwl/basewidget/fwl_editimp.cpp:756: FDE_TXTEDTPARAMS* pParams =
m_pEdtEngine->GetEditParams();
On 2016/04/28 14:59:39, dsinclair wrote:
> The cast was casting away the const. I removed the const from the method to
make
> it clear we could edit the result.

Acknowledged.

https://codereview.chromium.org/1927973003/diff/1/xfa/fwl/basewidget/fwl_edit...
xfa/fwl/basewidget/fwl_editimp.cpp:1600: if (m_pEdtEngine)
nit: not sure why, but early return seems less simple than

if (!m_pEdtEngine)
  m_pEdtEngine = new CFDE_TxtEdtEngine;

[dsinclair, 2016-04-28 17:35:57]

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtbuf.h
File xfa/fee/fde_txtedtbuf.h (right):

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtbuf.h#new...
xfa/fee/fde_txtedtbuf.h:13: #define FDE_DEFCHUNKLENGTH (1024)
On 2016/04/28 16:51:09, Tom Sepez wrote:
> nit: why ()?

Moved to an anonymous const inside the .cpp.

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtbuf.h#new...
xfa/fee/fde_txtedtbuf.h:53: int32_t nCount = -1) const;
On 2016/04/28 16:51:09, Tom Sepez wrote:
> nit: sp. nBegin

Done.

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtbuf.h#new...
xfa/fee/fde_txtedtbuf.h:59: FX_BOOL Optimize(IFX_Pause* pPause = NULL);
On 2016/04/28 16:51:09, Tom Sepez wrote:
> nit: nullptr

Done.

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtparag.h
File xfa/fee/fde_txtedtparag.h (right):

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/fde_txtedtparag.h#n...
xfa/fee/fde_txtedtparag.h:27: int32_t m_nCharStart;
On 2016/04/28 16:51:09, Tom Sepez wrote:
> can these be private given the Get* methods above?

Added Set methods and updated the code to actually call the Get methods.

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/ifde_txtedtengine.h
File xfa/fee/ifde_txtedtengine.h (right):

https://codereview.chromium.org/1927973003/diff/1/xfa/fee/ifde_txtedtengine.h...
xfa/fee/ifde_txtedtengine.h:94: pFont(NULL),
On 2016/04/28 16:51:09, Tom Sepez wrote:
> nit: nullptr (also below)

Done.

https://codereview.chromium.org/1927973003/diff/1/xfa/fwl/basewidget/fwl_edit...
File xfa/fwl/basewidget/fwl_editimp.cpp (right):

https://codereview.chromium.org/1927973003/diff/1/xfa/fwl/basewidget/fwl_edit...
xfa/fwl/basewidget/fwl_editimp.cpp:1600: if (m_pEdtEngine)
On 2016/04/28 16:51:09, Tom Sepez wrote:
> nit: not sure why, but early return seems less simple than
> 
> if (!m_pEdtEngine)
>   m_pEdtEngine = new CFDE_TxtEdtEngine;
> 

Done.

[Tom Sepez, 2016-04-29 15:36:23]

lgtm

https://codereview.chromium.org/1927973003/diff/20001/xfa/fee/fde_txtedtengin...
File xfa/fee/fde_txtedtengine.cpp (right):

https://codereview.chromium.org/1927973003/diff/20001/xfa/fee/fde_txtedtengin...
xfa/fee/fde_txtedtengine.cpp:918:
m_ParagPtrArray[i]->SetStartIndex(m_ParagPtrArray[i]->GetStartIndex() -
Feels like we should have incrementStatIndex and decrementStartIndex methods to
make this cleaner.

[dsinclair, 2016-05-02 13:36:50]

https://codereview.chromium.org/1927973003/diff/20001/xfa/fee/fde_txtedtengin...
File xfa/fee/fde_txtedtengine.cpp (right):

https://codereview.chromium.org/1927973003/diff/20001/xfa/fee/fde_txtedtengin...
xfa/fee/fde_txtedtengine.cpp:918:
m_ParagPtrArray[i]->SetStartIndex(m_ParagPtrArray[i]->GetStartIndex() -
On 2016/04/29 15:36:23, Tom Sepez wrote:
> Feels like we should have incrementStatIndex and decrementStartIndex methods
to
> make this cleaner.

Done.

[dsinclair, 2016-05-02 13:36:55]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-02 13:36:55]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1927973003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-02 13:37:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927973003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927973003/40001

[commit-bot: I haz the power, 2016-05-02 13:50:02]

Description was changed from

==========
Remove IFDE_TxtEdt interfaces where possible.

This CL removes the following and uses the only instance instead.
  * IFDE_TxtEdtParag
  * IFDE_TxtEdtEventSink
  * IFDE_TxtEdtEngine
  * IFDE_TxtEdtBuf
==========

to

==========
Remove IFDE_TxtEdt interfaces where possible.

This CL removes the following and uses the only instance instead.
  * IFDE_TxtEdtParag
  * IFDE_TxtEdtEventSink
  * IFDE_TxtEdtEngine
  * IFDE_TxtEdtBuf

Committed:
https://pdfium.googlesource.com/pdfium/+/b696f7d616ef397a01af1d6bd01c061922a2...
==========

[commit-bot: I haz the power, 2016-05-02 13:50:03]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/b696f7d616ef397a01af1d6bd01c061922a2...