pkg/compiler/lib/src/constants/expressions.dart - Issue 1927963002: Support compilation of Hello World

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/constants/expressions.dart

Issue 1927963002: Support compilation of Hello World (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/constants/expressions.dart

diff --git a/pkg/compiler/lib/src/constants/expressions.dart b/pkg/compiler/lib/src/constants/expressions.dart

index aa284cd20ceb174fe169a5ec994c99f4c2c0eed2..f7d06e227dd1fff6898915c4a8be2f1a951add47 100644

--- a/pkg/compiler/lib/src/constants/expressions.dart

+++ b/pkg/compiler/lib/src/constants/expressions.dart

@@ -680,8 +680,7 @@ class SymbolConstantExpression extends ConstantExpression {

@override

ConstantValue evaluate(

Environment environment, ConstantSystem constantSystem) {

- // TODO(johnniwinther): Implement this.

- throw new UnsupportedError('SymbolConstantExpression.evaluate');

+ return constantSystem.createSymbol(environment.compiler, name);

}

@override