Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1927953004: Reland of "Convert Widevine and Android platform key systems to KeySystemProperties" with fix (Closed)

Created:
4 years, 7 months ago by halliwell
Modified:
4 years, 7 months ago
Reviewers:
michaelbai, ddorwin, sky
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, android-webview-reviews_chromium.org, halliwell+watch_chromium.org, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Convert Widevine and Android platform key systems to KeySystemProperties" with fix This reverts commit ee270d6ac0b30e5d7c028a849ccd96eb82581cab. WidevineKeySystemProperties replaces the use of KeySystemInfo + InfoBasedKeySystemProperties for widevine (logic is essentially copied). Also updated Android platform key systems as it's simpler to convert the APIs in android_key_systems together. BUG=457438 TBR=sky,ddorwin,michaelbai Committed: https://crrev.com/8f42dd5a912f493b232908377a744906199811c1 Cr-Commit-Position: refs/heads/master@{#390661}

Patch Set 1 : original change #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -196 lines) Patch
M android_webview/renderer/aw_content_renderer_client.h View 1 chunk +3 lines, -1 line 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_key_systems.h View 1 chunk +4 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_key_systems.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.h View 1 chunk +15 lines, -2 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 1 5 chunks +21 lines, -13 lines 0 comments Download
M chromecast/renderer/cast_content_renderer_client.h View 1 chunk +4 lines, -1 line 0 comments Download
M chromecast/renderer/cast_content_renderer_client.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M chromecast/renderer/key_systems_cast.h View 1 chunk +6 lines, -7 lines 0 comments Download
M chromecast/renderer/key_systems_cast.cc View 3 chunks +24 lines, -19 lines 0 comments Download
M components/cdm.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M components/cdm/renderer/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cdm/renderer/android_key_systems.h View 1 chunk +6 lines, -3 lines 0 comments Download
M components/cdm/renderer/android_key_systems.cc View 6 chunks +77 lines, -31 lines 0 comments Download
A components/cdm/renderer/widevine_key_system_properties.h View 1 chunk +66 lines, -0 lines 0 comments Download
A components/cdm/renderer/widevine_key_system_properties.cc View 1 chunk +176 lines, -0 lines 0 comments Download
D components/cdm/renderer/widevine_key_systems.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/cdm/renderer/widevine_key_systems.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M media/base/key_system_properties.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927953004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927953004/20001
4 years, 7 months ago (2016-04-29 14:51:18 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 16:06:43 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:10 UTC) #4
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f42dd5a912f493b232908377a744906199811c1
Cr-Commit-Position: refs/heads/master@{#390661}

Powered by Google App Engine
This is Rietveld 408576698