Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: src/ast/ast-numbering.h

Issue 1927943003: Assign yield ids in ast-numbering rather than in bytecode-generator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/ast.h ('k') | src/ast/ast-numbering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_AST_AST_NUMBERING_H_ 5 #ifndef V8_AST_AST_NUMBERING_H_
6 #define V8_AST_AST_NUMBERING_H_ 6 #define V8_AST_AST_NUMBERING_H_
7 7
8 namespace v8 { 8 namespace v8 {
9 namespace internal { 9 namespace internal {
10 10
11 // Forward declarations. 11 // Forward declarations.
12 class FunctionLiteral; 12 class FunctionLiteral;
13 class Isolate; 13 class Isolate;
14 class Zone; 14 class Zone;
15 15
16 namespace AstNumbering { 16 namespace AstNumbering {
17 // Assign type feedback IDs and bailout IDs to an AST node tree. For a 17 // Assign type feedback IDs, bailout IDs, and generator yield IDs to an AST node
18 // generator function, also annotate the function itself and any loops therein 18 // tree.
19 // with the number of contained yields.
20 bool Renumber(Isolate* isolate, Zone* zone, FunctionLiteral* function); 19 bool Renumber(Isolate* isolate, Zone* zone, FunctionLiteral* function);
21 } 20 }
22 21
22 // Some details on yield IDs
23 // -------------------------
24 //
25 // In order to assist Ignition in generating bytecode for a generator function,
26 // we assign a unique number (the yield ID) to each Yield node in its AST. We
27 // also annotate loops with the number of yields they contain (loop.yield_count)
28 // and the smallest ID of those (loop.first_yield_id), and we annotate the
29 // function itself with the number of yields it contains (function.yield_count).
30 //
31 // The way in which we choose the IDs is simply by enumerating the Yield nodes.
32 // Ignition relies on the following properties:
33 // - For each loop l and each yield y of l:
34 // l.first_yield_id <= y.yield_id < l.first_yield_id + l.yield_count
35 // - For the generator function f itself and each yield y of f:
36 // 0 <= y.yield_id < f.yield_count
37
23 } // namespace internal 38 } // namespace internal
24 } // namespace v8 39 } // namespace v8
25 40
26 #endif // V8_AST_AST_NUMBERING_H_ 41 #endif // V8_AST_AST_NUMBERING_H_
OLDNEW
« no previous file with comments | « src/ast/ast.h ('k') | src/ast/ast-numbering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698