Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1927893002: Port arm, arm64, mipsle, and mips64le flags to GN (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Port arm, arm64, mipsle, and mips64le flags to GN BUG=chromium:607461 R=machenbach@chromium.org,brettw@chromium.org LOG=n Committed: https://crrev.com/f580f76503286c56742a9148455e50d3d41390c6 Cr-Commit-Position: refs/heads/master@{#35922}

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 2

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -25 lines) Patch
M BUILD.gn View 1 2 2 chunks +76 lines, -25 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-04-28 10:28:40 UTC) #1
jochen (gone - plz use gerrit)
when I apply this patch, e.g. the mksnapshot.cc file still is not compiled with -DCAN_USE_NEON. ...
4 years, 7 months ago (2016-04-28 10:31:25 UTC) #3
brettw
lgtm
4 years, 7 months ago (2016-04-29 19:21:50 UTC) #4
Dirk Pranke
lgtm also.
4 years, 7 months ago (2016-04-29 19:33:54 UTC) #5
jochen (gone - plz use gerrit)
ptal I added the other archs as well
4 years, 7 months ago (2016-05-02 07:10:19 UTC) #7
Michael Achenbach
https://codereview.chromium.org/1927893002/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1927893002/diff/20001/BUILD.gn#newcode222 BUILD.gn:222: defines += [ "__mips_hard_float=0" ] In toolchain.gypi there is ...
4 years, 7 months ago (2016-05-02 07:41:35 UTC) #8
jochen (gone - plz use gerrit)
done, ptal
4 years, 7 months ago (2016-05-02 07:45:21 UTC) #9
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-02 07:56:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927893002/40001
4 years, 7 months ago (2016-05-02 07:59:53 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-02 08:10:37 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 08:11:57 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f580f76503286c56742a9148455e50d3d41390c6
Cr-Commit-Position: refs/heads/master@{#35922}

Powered by Google App Engine
This is Rietveld 408576698