Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/interpreter/interpreter.h

Issue 1927873002: Revert of [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Merged. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INTERPRETER_INTERPRETER_H_ 5 #ifndef V8_INTERPRETER_INTERPRETER_H_
6 #define V8_INTERPRETER_INTERPRETER_H_ 6 #define V8_INTERPRETER_INTERPRETER_H_
7 7
8 // Clients of this interface shouldn't depend on lots of interpreter internals. 8 // Clients of this interface shouldn't depend on lots of interpreter internals.
9 // Do not include anything from src/interpreter other than 9 // Do not include anything from src/interpreter other than
10 // src/interpreter/bytecodes.h here! 10 // src/interpreter/bytecodes.h here!
11 #include "src/base/macros.h" 11 #include "src/base/macros.h"
12 #include "src/builtins.h" 12 #include "src/builtins.h"
13 #include "src/interpreter/bytecodes.h" 13 #include "src/interpreter/bytecodes.h"
14 #include "src/parsing/token.h" 14 #include "src/parsing/token.h"
15 #include "src/runtime/runtime.h" 15 #include "src/runtime/runtime.h"
16 16
17 namespace v8 { 17 namespace v8 {
18 namespace internal { 18 namespace internal {
19 19
20 class Isolate; 20 class Isolate;
21 class Callable; 21 class Callable;
22 class CompilationInfo; 22 class CompilationInfo;
23 23
24 namespace compiler {
25 class Node;
26 } // namespace compiler
27
28 namespace interpreter { 24 namespace interpreter {
29 25
30 class InterpreterAssembler; 26 class InterpreterAssembler;
31 27
32 class Interpreter { 28 class Interpreter {
33 public: 29 public:
34 explicit Interpreter(Isolate* isolate); 30 explicit Interpreter(Isolate* isolate);
35 virtual ~Interpreter() {} 31 virtual ~Interpreter() {}
36 32
37 // Initializes the interpreter dispatch table. 33 // Initializes the interpreter dispatch table.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 BYTECODE_LIST(DECLARE_BYTECODE_HANDLER_GENERATOR) 66 BYTECODE_LIST(DECLARE_BYTECODE_HANDLER_GENERATOR)
71 #undef DECLARE_BYTECODE_HANDLER_GENERATOR 67 #undef DECLARE_BYTECODE_HANDLER_GENERATOR
72 68
73 // Generates code to perform the binary operations via |callable|. 69 // Generates code to perform the binary operations via |callable|.
74 void DoBinaryOp(Callable callable, InterpreterAssembler* assembler); 70 void DoBinaryOp(Callable callable, InterpreterAssembler* assembler);
75 71
76 // Generates code to perform the binary operations via |function_id|. 72 // Generates code to perform the binary operations via |function_id|.
77 void DoBinaryOp(Runtime::FunctionId function_id, 73 void DoBinaryOp(Runtime::FunctionId function_id,
78 InterpreterAssembler* assembler); 74 InterpreterAssembler* assembler);
79 75
80 // Generates code to perform the binary operations via |Generator|.
81 template <class Generator>
82 void DoBinaryOp(InterpreterAssembler* assembler);
83
84 // Generates code to perform the count operations via |callable|. 76 // Generates code to perform the count operations via |callable|.
85 void DoCountOp(Callable callable, InterpreterAssembler* assembler); 77 void DoCountOp(Callable callable, InterpreterAssembler* assembler);
86 78
87 // Generates code to perform the comparison operation associated with 79 // Generates code to perform the comparison operation associated with
88 // |compare_op|. 80 // |compare_op|.
89 void DoCompareOp(Token::Value compare_op, InterpreterAssembler* assembler); 81 void DoCompareOp(Token::Value compare_op, InterpreterAssembler* assembler);
90 82
91 // Generates code to load a constant from the constant pool. 83 // Generates code to load a constant from the constant pool.
92 void DoLoadConstant(InterpreterAssembler* assembler); 84 void DoLoadConstant(InterpreterAssembler* assembler);
93 85
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 v8::base::SmartArrayPointer<uintptr_t> bytecode_dispatch_counters_table_; 152 v8::base::SmartArrayPointer<uintptr_t> bytecode_dispatch_counters_table_;
161 153
162 DISALLOW_COPY_AND_ASSIGN(Interpreter); 154 DISALLOW_COPY_AND_ASSIGN(Interpreter);
163 }; 155 };
164 156
165 } // namespace interpreter 157 } // namespace interpreter
166 } // namespace internal 158 } // namespace internal
167 } // namespace v8 159 } // namespace v8
168 160
169 #endif // V8_INTERPRETER_INTERPRETER_H_ 161 #endif // V8_INTERPRETER_INTERPRETER_H_
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698