Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1927873002: Revert of [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. (Closed)

Created:
4 years, 7 months ago by epertoso
Modified:
4 years, 7 months ago
CC:
oth, rmcilroy, v8-reviews_googlegroups.com, Mircea Trofin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. (patchset #4 id:60001 of https://codereview.chromium.org/1902823002/ ) Reason for revert: Caused a performance regression in TurboFan and did not improve in a significant way Ignition's performances. Original issue's description: > [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. > > Adds a Generate method to the stubs that can be used to embed the graph directly in the bytecode handlers. > > Committed: https://crrev.com/e8caf78ff2a9f7d50ac9b47f6b4c80f92b69914a > Cr-Commit-Position: refs/heads/master@{#35696} TBR=bmeurer@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/941f553574a116d970ca9ac341802f1e0e759b14 Cr-Commit-Position: refs/heads/master@{#35851}

Patch Set 1 #

Patch Set 2 : Merged. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -188 lines) Patch
M src/code-stubs.h View 1 12 chunks +11 lines, -23 lines 0 comments Download
M src/code-stubs.cc View 1 25 chunks +105 lines, -136 lines 0 comments Download
M src/interpreter/interpreter.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 11 chunks +11 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
epertoso
Created Revert of [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.
4 years, 7 months ago (2016-04-28 08:38:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927873002/1
4 years, 7 months ago (2016-04-28 08:38:35 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/844) v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-04-28 08:40:06 UTC) #4
Michael Achenbach
On 2016/04/28 08:40:06, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-04-28 08:49:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927873002/150001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927873002/150001
4 years, 7 months ago (2016-04-28 09:24:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:150001)
4 years, 7 months ago (2016-04-28 10:02:50 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/941f553574a116d970ca9ac341802f1e0e759b14
Cr-Commit-Position: refs/heads/master@{#35851}

Powered by Google App Engine
This is Rietveld 408576698