Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1825)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 1927863004: Revert of [Cronet] Avoid crashing when CronetEngines are created on multiple threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index 5fbfcbf4a43c4c234ea68988fec508afe9557723..5353b8a9cf40674832f1c17e5c0e1a26adf5d481 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -1125,30 +1125,4 @@
assertTrue(loader.wasCalled());
}
}
-
- // Creates a CronetEngine on another thread and then one on the main thread. This shouldn't
- // crash.
- @SmallTest
- @Feature({"Cronet"})
- public void testThreadedStartup() throws Exception {
- final ConditionVariable otherThreadDone = new ConditionVariable();
- final ConditionVariable uiThreadDone = new ConditionVariable();
- new Handler(Looper.getMainLooper()).post(new Runnable() {
- public void run() {
- final CronetEngine.Builder builder =
- new CronetEngine.Builder(getContext()).setLibraryName("cronet_tests");
- new Thread() {
- public void run() {
- CronetEngine cronetEngine = builder.build();
- otherThreadDone.open();
- cronetEngine.shutdown();
- }
- }.start();
- otherThreadDone.block();
- builder.build().shutdown();
- uiThreadDone.open();
- }
- });
- assertTrue(uiThreadDone.block(1000));
- }
}
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698