Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1927863004: Revert of [Cronet] Avoid crashing when CronetEngines are created on multiple threads (Closed)

Created:
4 years, 7 months ago by pasko
Modified:
4 years, 7 months ago
Reviewers:
pauljensen, kapishnikov, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Cronet] Avoid crashing when CronetEngines are created on multiple threads (patchset #2 id:20001 of https://codereview.chromium.org/1926683003/ ) Reason for revert: CronetUrlRequestContextTest#testSkipLibraryLoading fails on public cronet bots: http://crbug.com/607464 Original issue's description: > [Cronet] Avoid crashing when CronetEngines are created on multiple threads > > Creating a CronetEngine on one thread calls > CronetLibraryLoader.ensureInitialized() which posts to the main thread, but > if a CronetEngine is created immediately after this on the main thread without > first returning to the message loop, that initialization won't have happened > and the initialization of the CronetEngine being created on the main thread > could crash when it tries to get the current native MessageLoop. > > BUG=607178 TBR=mef@chromium.org,kapishnikov@chromium.org,pauljensen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607178 Committed: https://crrev.com/53d985cf3f606aa5fb0e157654da21c4691d6fb8 Cr-Commit-Position: refs/heads/master@{#390341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -49 lines) Patch
M components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java View 4 chunks +10 lines, -21 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java View 2 chunks +1 line, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pasko
Created Revert of [Cronet] Avoid crashing when CronetEngines are created on multiple threads
4 years, 7 months ago (2016-04-28 10:47:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927863004/1
4 years, 7 months ago (2016-04-28 10:47:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 10:47:55 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53d985cf3f606aa5fb0e157654da21c4691d6fb8
Cr-Commit-Position: refs/heads/master@{#390341}

Powered by Google App Engine
This is Rietveld 408576698