git-templates/hooks/applypatch-msg - Issue 19278004: Use plain sh instead of bash in the git template hooks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: git-templates/hooks/applypatch-msg

Issue 19278004: Use plain sh instead of bash in the git template hooks. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/bin/bash	1 #!/bin/sh
	Isaac (away) 2013/07/29 08:15:10 These lines look fine. These lines look fine.
2	2

3 [ -e "build/git-hooks/applypatch-msg" ] && exec bash "build/git-hooks/applypatch -msg" "$@"	3 [ -e "build/git-hooks/applypatch-msg" ] && exec sh "build/git-hooks/applypatch-m sg" "$@"
	Isaac (away) 2013/07/29 08:15:10 Can we exec the script directly -- i.e. remove the Can we exec the script directly -- i.e. remove the bash/sh from these lines? Isaac (away) 2013/07/29 08:18:01 Actually -- I'm pretty confident it is OK to remov Show quoted text On 2013/07/29 08:15:10, Isaac wrote: > Can we exec the script directly -- i.e. remove the bash/sh from these lines? Actually -- I'm pretty confident it is OK to remove the bash/sh from these lines. Could you upload a fresh patch w/ that?
4 exit 0	4 exit 0
	Isaac (away) 2013/07/29 08:24:53 also exit 0 is redundant, can you remove these lin also exit 0 is redundant, can you remove these lines too?
OLD	NEW

« no previous file with comments | « no previous file | git-templates/hooks/post-applypatch » ('j') | no next file with comments »