Reland Implement owners check in presubmit for Gerrit.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld and Gerrit."""
 
 from distutils.version import LooseVersion
@@ skipping 77 matching lines @@
   sys.exit(1)
 
 
 def GetNoGitPagerEnv():
   env = os.environ.copy()
   # 'cat' is a magical git string that disables pagers on all platforms.
   env['GIT_PAGER'] = 'cat'
   return env
 
 
 def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):

[tandrii(chromium), 2016/04/29 16:01:13]

rebase artifact :(

   try:
     return subprocess2.check_output(args, shell=shell, **kwargs)
   except subprocess2.CalledProcessError as e:
     logging.debug('Failed running %s', args)
     if not error_ok:
       DieWithError(
           'Command "%s" failed.\n%s' % (
             ' '.join(args), error_message or e.stdout or ''))
     return e.stdout
 
@@ skipping 1201 matching lines @@
   def UpdateDescription(self, description):
     self.description = description
     return self._codereview_impl.UpdateDescriptionRemote(description)
 
   def RunHook(self, committing, may_prompt, verbose, change):
     """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
     try:
       return presubmit_support.DoPresubmitChecks(change, committing,
           verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
           default_presubmit=None, may_prompt=may_prompt,
-          rietveld_obj=self._codereview_impl.GetRieveldObjForPresubmit())
+          rietveld_obj=self._codereview_impl.GetRieveldObjForPresubmit(),
+          gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
     except presubmit_support.PresubmitFailure, e:
       DieWithError(
           ('%s\nMaybe your depot_tools is out of date?\n'
            'If all fails, contact maruel@') % e)
 
   def CMDPatchIssue(self, issue_arg, reject, nocommit, directory):
     """Fetches and applies the issue patch from codereview to local branch."""
     if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
       parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
     else:
@@ skipping 163 matching lines @@
 
   def PatchsetSetting(self):
     """Returns name of git config setting which stores issue number."""
     raise NotImplementedError()
 
   def GetRieveldObjForPresubmit(self):
     # This is an unfortunate Rietveld-embeddedness in presubmit.
     # For non-Rietveld codereviews, this probably should return a dummy object.
     raise NotImplementedError()
 
+  def GetGerritObjForPresubmit(self):
+    # None is valid return value, otherwise presubmit_support.GerritAccessor.
+    return None
+
   def UpdateDescriptionRemote(self, description):
     """Update the description on codereview site."""
     raise NotImplementedError()
 
   def CloseIssue(self):
     """Closes the issue."""
     raise NotImplementedError()
 
   def GetApprovingReviewers(self):
     """Returns a list of reviewers approving the change.
@@ skipping 586 matching lines @@
       def __getattr__(self, attr):
         print(
             'You aren\'t using Rietveld at the moment, but Gerrit.\n'
             'Using Rietveld in your PRESUBMIT scripts won\'t work.\n'
             'Please, either change your PRESUBIT to not use rietveld_obj.%s,\n'
             'or use Rietveld for codereview.\n'
             'See also http://crbug.com/579160.' % attr)
         raise NotImplementedError()
     return ThisIsNotRietveldIssue()
 
+  def GetGerritObjForPresubmit(self):
+    return presubmit_support.GerritAccessor(self._GetGerritHost())
+
   def GetStatus(self):
     """Apply a rough heuristic to give a simple summary of an issue's review
     or CQ status, assuming adherence to a common workflow.
 
     Returns None if no issue for this branch, or one of the following keywords:
       * 'error'    - error from review tool (including deleted issues)
       * 'unsent'   - no reviewers added
       * 'waiting'  - waiting for review
       * 'reply'    - waiting for owner to reply to review
       * 'not lgtm' - Code-Review -2 from at least one approved reviewer
@@ skipping 2622 matching lines @@
              'found in this checkout. Files in other languages are still ' +
              'formatted.')
 
   # Format GN build files. Always run on full build files for canonical form.
   if gn_diff_files:
     cmd = ['gn', 'format']
     if not opts.dry_run and not opts.diff:
       cmd.append('--in-place')
     for gn_diff_file in gn_diff_files:
       stdout = RunCommand(cmd + [gn_diff_file],
                           shell=sys.platform == 'win32',

[tandrii(chromium), 2016/04/29 16:01:13]

rebase artifact :(

                           cwd=top_dir)
       if opts.diff:
         sys.stdout.write(stdout)
 
   return return_value
 
 
 @subcommand.usage('<codereview url or issue id>')
 def CMDcheckout(parser, args):
   """Checks out a branch associated with a given Rietveld or Gerrit issue."""
@@ skipping 94 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   setup_color.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)