Disambiguate extension dialog string.

Disambiguate extension dialog string.

Add a meaning tag to IDS_EXTENSION_PROMPT_WARNING_HOSTS_MANY to disambiguate
it from IDS_EXTENSION_PROMPT_WARNING_HOSTS_DEFAULT, which has the same text
but is used in a different plural case.

BUG=342370
TBR=joi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255961

[tony, 2014-03-10 17:37:21]

Committed patchset #1 manually as r255961 (presubmit successful).

[Jói, 2014-03-10 17:51:46]

Unrelated to your specific change, but note that the description says
"for access to data on four or more websites" and then later,
"NUMBER_OF_WEBSITES is 11 through 99". Seems like a discrepancy to me.

Perhaps, for future maintainability, the meaning string should be
"11through99"?

Cheers,
Jói


On Mon, Mar 10, 2014 at 5:37 PM,  <tony@chromium.org> wrote:
> Reviewers: Jói,
>
> Message:
> Committed patchset #1 manually as r255961 (presubmit successful).
>
> Description:
> Disambiguate extension dialog string.
>
> Add a meaning tag to IDS_EXTENSION_PROMPT_WARNING_HOSTS_MANY to disambiguate
> it from IDS_EXTENSION_PROMPT_WARNING_HOSTS_DEFAULT, which has the same text
> but is used in a different plural case.
>
> BUG=342370
> TBR=joi@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255961
>
> Please review this at https://codereview.chromium.org/192773005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+1, -1 lines):
>   M chrome/app/generated_resources.grd
>
>
> Index: chrome/app/generated_resources.grd
> diff --git a/chrome/app/generated_resources.grd
> b/chrome/app/generated_resources.grd
> index
>
a173d513838897ad18198042b7420dfc5c20f0fc..3c0bf2846ff9822273cdc3151da08b7f6d7d90c6
> 100644
> --- a/chrome/app/generated_resources.grd
> +++ b/chrome/app/generated_resources.grd
> @@ -4403,7 +4403,7 @@ Make sure you do not expose any sensitive information.
>        </if>
>
>        <if expr="lang == 'ar'">
> -      <message name="IDS_EXTENSION_PROMPT_WARNING_HOSTS_MANY"
> desc="Permission string for access to data on four or more websites.
> NUMBER_OF_WEBSITES is 11 through 99 in Arabic. For all other languages, do
> NOT translate.">
> +      <message name="IDS_EXTENSION_PROMPT_WARNING_HOSTS_MANY"
> meaning="many" desc="Permission string for access to data on four or more
> websites. NUMBER_OF_WEBSITES is 11 through 99 in Arabic. For all other
> languages, do NOT translate.">
>          Access your data on <ph name="NUMBER_OF_WEBSITES">#<ex>23</ex></ph>
> websites
>        </message>
>        </if>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.