Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2172)

Issue 1927703002: Revert of Fix InlineTextBox::characterWidths() not to measure every substring (Closed)

Created:
4 years, 7 months ago by Justin Donnelly
Modified:
4 years, 7 months ago
Reviewers:
kojii
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Revert of Fix InlineTextBox::characterWidths() not to measure every substring (patchset #1 id:1 of https://codereview.chromium.org/1919143005/ ) Reason for revert: Broke the mac stable builder: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20stable/builds/615 ----- Log output copied here for convenience: ../../third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp:33:10: fatal error: 'platform/fonts/CharacterRange.h' file not found #include "platform/fonts/CharacterRange.h" ^ 1 error generated. ninja: build stopped: subcommand failed. Original issue's description: > Fix InlineTextBox::characterWidths() not to measure every substring > > This patch changes InlineTextBox::characterWidths() to use > Font::individualCharacterRanges() rather than to measure every > substring of InlineTextBox. Measuring every substring without context > is very expensive and also is not correct. > > When dev tools have long strings without spaces such as minified JS and > accessbility is turned on, the measuring of substrings can almost hang > it up. > > Currently, WebAXObject::characterOffsets() is the only user of this > function. > > BUG=593679, 568032 > TEST=Existing tests cover, such as AutomationApiTest.BoundsForRange > > Review URL: https://codereview.chromium.org/1897853004 > > Cr-Commit-Position: refs/heads/master@{#388162} > (cherry picked from commit 11f1c680cca2250e01121b9bddd7bc6f8fb28a96) > > Committed: https://chromium.googlesource.com/chromium/src/+/a3b71a920f64013793487faebeadc648c1a0774b TBR=kojii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=593679, 568032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Justin Donnelly
Created Revert of Fix InlineTextBox::characterWidths() not to measure every substring
4 years, 7 months ago (2016-04-27 19:28:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927703002/1
4 years, 7 months ago (2016-04-27 19:29:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927703002/1
4 years, 7 months ago (2016-04-27 19:31:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 19:32:35 UTC) #5
kojii
4 years, 7 months ago (2016-04-28 00:55:30 UTC) #6
Message was sent while issue was closed.
On 2016/04/27 at 19:32:35, commit-bot wrote:
> Committed patchset #1 (id:1)

lgtm, thank you for helping this.

Powered by Google App Engine
This is Rietveld 408576698