Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1927643002: 👒 Delete all isolate_file for test() template (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, toyoshim+midi_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete all isolate_file for test() template Isolate files for test()s are now generated by GN from runtime_deps. BUG=589318 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/fc41d88139fdf3a9b62ea96e54803d7bcec9dfbe Cr-Commit-Position: refs/heads/master@{#390170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -58 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M media/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M net/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sql/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
M sync/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M testing/test.gni View 1 chunk +1 line, -8 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
agrieve
4 years, 7 months ago (2016-04-27 17:37:08 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927643002/1
4 years, 7 months ago (2016-04-27 17:37:54 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 18:47:28 UTC) #7
brettw
lgtm
4 years, 7 months ago (2016-04-27 20:22:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927643002/1
4 years, 7 months ago (2016-04-27 20:34:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 20:40:14 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:12:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc41d88139fdf3a9b62ea96e54803d7bcec9dfbe
Cr-Commit-Position: refs/heads/master@{#390170}

Powered by Google App Engine
This is Rietveld 408576698