Remove DrawGLFunctor CleanupReference.

Remove DrawGLFunctor CleanupReference.

Instead of having Java DrawGLFunctor register a CleanupReference to
destroy its native counterpart, it provides a method to get a destroy
runnable that performs this function, and it is up to the owner of the
Java DrawGLFunctor object to call it at the appropriate time (i.e. when
the native DrawGLFunctor is no longer referenced by the render thread
display list).

The AwGLFunctor DestroyRunnable holds a reference to the DrawGLFunctor
DestroyRunnable, so that it can call it once AwGLFunctor is GC'ed.

BUG=597167
Committed: https://crrev.com/fece06881fde15ddb181b3af43c3912457fca427
Cr-Commit-Position: refs/heads/master@{#390130}

[Tobias Sargeant, 2016-04-27 16:29:12]

tobiasjs@chromium.org changed reviewers:
+ boliu@chromium.org

[boliu, 2016-04-27 17:08:47]

lgtm % asserts + test

https://codereview.chromium.org/1927543003/diff/1/android_webview/glue/java/s...
File
android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java
(right):

https://codereview.chromium.org/1927543003/diff/1/android_webview/glue/java/s...
android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java:74:
return mDestroyRunnable;
Assert everywhere mNativeDrawGLFunctor is used that it's not 0

https://codereview.chromium.org/1927543003/diff/1/android_webview/test/shell/...
File
android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
(right):

https://codereview.chromium.org/1927543003/diff/1/android_webview/test/shell/...
android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java:458:
return new Runnable() {
this needs to be static to make the gc tests pass

https://codereview.chromium.org/1927543003/diff/1/android_webview/test/shell/...
android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java:461:
mContext = 0;
maybe assert everywhere mContext is used that it's not 0?

[Tobias Sargeant, 2016-04-27 17:29:49]

https://codereview.chromium.org/1927543003/diff/1/android_webview/test/shell/...
File
android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
(right):

https://codereview.chromium.org/1927543003/diff/1/android_webview/test/shell/...
android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java:458:
return new Runnable() {
On 2016/04/27 17:08:46, boliu wrote:
> this needs to be static to make the gc tests pass

Acknowledged.

https://codereview.chromium.org/1927543003/diff/1/android_webview/test/shell/...
android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java:461:
mContext = 0;
On 2016/04/27 17:08:46, boliu wrote:
> maybe assert everywhere mContext is used that it's not 0?

mContext is passed to requestRender as viewContext, and I added the assert.

[Tobias Sargeant, 2016-04-27 17:30:15]

The CQ bit was checked by tobiasjs@chromium.org

[Tobias Sargeant, 2016-04-27 17:30:15]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/1927543003/#ps20001
(title: "make Runnable static, throw if native DrawGLFunctor destroyed")

[commit-bot: I haz the power, 2016-04-27 17:30:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927543003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927543003/20001

[commit-bot: I haz the power, 2016-04-27 18:13:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:11:22]

Patchset 2 (id:??) landed as
https://crrev.com/fece06881fde15ddb181b3af43c3912457fca427
Cr-Commit-Position: refs/heads/master@{#390130}

[commit-bot: I haz the power, 2016-04-30 17:50:56]

Description was changed from

==========
Remove DrawGLFunctor CleanupReference.

Instead of having Java DrawGLFunctor register a CleanupReference to
destroy its native counterpart, it provides a method to get a destroy
runnable that performs this function, and it is up to the owner of the
Java DrawGLFunctor object to call it at the appropriate time (i.e. when
the native DrawGLFunctor is no longer referenced by the render thread
display list).

The AwGLFunctor DestroyRunnable holds a reference to the DrawGLFunctor
DestroyRunnable, so that it can call it once AwGLFunctor is GC'ed.

BUG=597167
==========

to

==========
Remove DrawGLFunctor CleanupReference.

Instead of having Java DrawGLFunctor register a CleanupReference to
destroy its native counterpart, it provides a method to get a destroy
runnable that performs this function, and it is up to the owner of the
Java DrawGLFunctor object to call it at the appropriate time (i.e. when
the native DrawGLFunctor is no longer referenced by the render thread
display list).

The AwGLFunctor DestroyRunnable holds a reference to the DrawGLFunctor
DestroyRunnable, so that it can call it once AwGLFunctor is GC'ed.

BUG=597167

Committed: https://crrev.com/fece06881fde15ddb181b3af43c3912457fca427
Cr-Commit-Position: refs/heads/master@{#390130}
==========