Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1927543002: [debugger] unskip mjsunit/debug-stepin-builtin-callback-opt. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] unskip mjsunit/debug-stepin-builtin-callback-opt. This test does not seem to fail any longer. R=machenbach@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/f8e44fb5aaaa80cf2d39bc3164f2c962a6b57f5e Cr-Commit-Position: refs/heads/master@{#35814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
4 years, 7 months ago (2016-04-27 09:54:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927543002/1
4 years, 7 months ago (2016-04-27 09:56:10 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-04-27 09:56:12 UTC) #5
Michael Achenbach
lgtm
4 years, 7 months ago (2016-04-27 09:57:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927543002/1
4 years, 7 months ago (2016-04-27 09:57:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 10:18:41 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f8e44fb5aaaa80cf2d39bc3164f2c962a6b57f5e Cr-Commit-Position: refs/heads/master@{#35814}
4 years, 7 months ago (2016-04-27 10:20:41 UTC) #11
Yang
4 years, 7 months ago (2016-04-27 10:53:04 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1931433002/ by yangguo@chromium.org.

The reason for reverting is: Now we do have a repro!

https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/....

Powered by Google App Engine
This is Rietveld 408576698