Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1927513002: [build] Remove deprecated gyp file. (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Remove deprecated gyp file. This has moved to src/v8.gyp in: https://codereview.chromium.org/1920793002/ BUG=chromium:474921 LOG=n NOTRY=true Committed: https://crrev.com/7752614f35dee27d4aecbea2d58602937a0cd510 Cr-Commit-Position: refs/heads/master@{#35812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2229 lines) Patch
D tools/gyp/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/gyp/v8.gyp View 1 chunk +0 lines, -2225 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927513002/1
4 years, 7 months ago (2016-04-27 09:16:15 UTC) #4
Michael Achenbach
PTAL
4 years, 7 months ago (2016-04-27 09:17:48 UTC) #6
Jakob Kummerow
lgtm
4 years, 7 months ago (2016-04-27 09:18:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927513002/1
4 years, 7 months ago (2016-04-27 09:21:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 09:24:07 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 09:25:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7752614f35dee27d4aecbea2d58602937a0cd510
Cr-Commit-Position: refs/heads/master@{#35812}

Powered by Google App Engine
This is Rietveld 408576698