Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1927503002: command_buffer: Remove unneeded FBO binding restore during CopyTextureCHROMIUM (Closed)

Created:
4 years, 7 months ago by Kimmo Kinnunen
Modified:
4 years, 7 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

command_buffer: Remove unneeded FBO binding restore during CopyTextureCHROMIUM Remove unneeded restoring of FBO bindings after creating CopyTextureCHROMIUM helper instance. CopyTextureCHROMIUMResourceManager::Initialize() does not change the FBO bindings at all, so the removed call GLES2DecoderImpl::RestoreCurrentFramebufferBindings should not be needed. This is a work aiming to improve decoder MakeCurrent performance by making more of the state updated in lazy manner. This works towards updating the logic for FBOs. Removing the extra FBO restore simplifies this. BUG=603407 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/50d4774a32f18c10e2cc5285fc26e187d088fcab Cr-Commit-Position: refs/heads/master@{#390333}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -80 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 18 chunks +59 lines, -80 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927503002/1
4 years, 7 months ago (2016-04-27 06:35:58 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 08:07:00 UTC) #5
Kimmo Kinnunen
4 years, 7 months ago (2016-04-27 12:53:11 UTC) #7
Zhenyao Mo
lgtm In the future I suggest to do logic change and code cleanup in separate ...
4 years, 7 months ago (2016-04-27 16:44:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927503002/1
4 years, 7 months ago (2016-04-28 07:58:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 09:03:41 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50d4774a32f18c10e2cc5285fc26e187d088fcab
Cr-Commit-Position: refs/heads/master@{#390333}

Powered by Google App Engine
This is Rietveld 408576698