Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: LayoutTests/editing/spelling/resources/util.js

Issue 19275006: Fix a use-after-free in spellcheck client (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/editing/spelling/resources/util.js
diff --git a/LayoutTests/editing/spelling/resources/util.js b/LayoutTests/editing/spelling/resources/util.js
index a178e06ba6d7fa50d10329ccf2f26dcd97dc9a60..7779d1ddecd0530edb2c5146691939e355bdf53b 100644
--- a/LayoutTests/editing/spelling/resources/util.js
+++ b/LayoutTests/editing/spelling/resources/util.js
@@ -29,7 +29,7 @@ function initSpellTest(testElementId, testText, testFunction)
internals.settings.setSelectTrailingWhitespaceEnabled(false);
internals.settings.setUnifiedTextCheckerEnabled(true);
internals.settings.setEditingBehavior("win");
- var destination = document.getElementById(testElementId);
+ destination = document.getElementById(testElementId);
abarth-chromium 2013/07/17 00:01:00 Maybe: window.destination = ... to make it clear
please use gerrit instead 2013/07/17 01:11:22 Done.
destination.focus();
document.execCommand("InsertText", false, testText);
window.setTimeout(function() { verifySpellTest(10); }, 0);

Powered by Google App Engine
This is Rietveld 408576698