Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 1927463002: Rename gfx::Display/Screen to display::Display/Screen in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index bc55e59f244badc7cf575151b82a8bb6eaf2f8ed..77c2e55ef97ffef2d037678183f6ccc0afbf6e7b 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -76,6 +76,8 @@
#include "ui/base/ui_base_types.h"
#include "ui/compositor/compositor_vsync_manager.h"
#include "ui/compositor/dip_util.h"
+#include "ui/display/display.h"
+#include "ui/display/screen.h"
#include "ui/events/blink/blink_event_util.h"
#include "ui/events/event.h"
#include "ui/events/event_utils.h"
@@ -83,11 +85,9 @@
#include "ui/events/gestures/gesture_recognizer.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/color_profile.h"
-#include "ui/gfx/display.h"
#include "ui/gfx/geometry/dip_util.h"
#include "ui/gfx/geometry/rect_conversions.h"
#include "ui/gfx/geometry/size_conversions.h"
-#include "ui/gfx/screen.h"
#include "ui/gfx/skia_util.h"
#include "ui/touch_selection/touch_selection_controller.h"
#include "ui/wm/public/activation_client.h"
@@ -169,9 +169,10 @@ bool IsXButtonUpEvent(const ui::MouseEvent* event) {
}
void GetScreenInfoForWindow(WebScreenInfo* results, aura::Window* window) {
- gfx::Screen* screen = gfx::Screen::GetScreen();
- const gfx::Display display = window ? screen->GetDisplayNearestWindow(window)
- : screen->GetPrimaryDisplay();
+ display::Screen* screen = display::Screen::GetScreen();
+ const display::Display display = window
+ ? screen->GetDisplayNearestWindow(window)
+ : screen->GetPrimaryDisplay();
results->rect = display.bounds();
results->availableRect = display.work_area();
// TODO(derat|oshima): Don't hardcode this. Get this from display object.
@@ -433,8 +434,8 @@ void RenderWidgetHostViewAura::InitAsChild(
if (parent_view)
parent_view->AddChild(GetNativeView());
- const gfx::Display display =
- gfx::Screen::GetScreen()->GetDisplayNearestWindow(window_);
+ const display::Display display =
+ display::Screen::GetScreen()->GetDisplayNearestWindow(window_);
device_scale_factor_ = display.device_scale_factor();
}
@@ -486,8 +487,8 @@ void RenderWidgetHostViewAura::InitAsPopup(
event_filter_for_popup_exit_.reset(new EventFilterForPopupExit(this));
- const gfx::Display display =
- gfx::Screen::GetScreen()->GetDisplayNearestWindow(window_);
+ const display::Display display =
+ display::Screen::GetScreen()->GetDisplayNearestWindow(window_);
device_scale_factor_ = display.device_scale_factor();
}
@@ -510,8 +511,8 @@ void RenderWidgetHostViewAura::InitAsFullscreen(
host_tracker_.reset(new aura::WindowTracker);
host_tracker_->Add(reference_window);
}
- gfx::Display display =
- gfx::Screen::GetScreen()->GetDisplayNearestWindow(reference_window);
+ display::Display display =
+ display::Screen::GetScreen()->GetDisplayNearestWindow(reference_window);
parent = reference_window->GetRootWindow();
bounds = display.bounds();
}
@@ -519,8 +520,8 @@ void RenderWidgetHostViewAura::InitAsFullscreen(
Show();
Focus();
- const gfx::Display display =
- gfx::Screen::GetScreen()->GetDisplayNearestWindow(window_);
+ const display::Display display =
+ display::Screen::GetScreen()->GetDisplayNearestWindow(window_);
device_scale_factor_ = display.device_scale_factor();
}
@@ -864,8 +865,8 @@ void RenderWidgetHostViewAura::SetInsets(const gfx::Insets& insets) {
void RenderWidgetHostViewAura::UpdateCursor(const WebCursor& cursor) {
current_cursor_ = cursor;
- const gfx::Display display =
- gfx::Screen::GetScreen()->GetDisplayNearestWindow(window_);
+ const display::Display display =
+ display::Screen::GetScreen()->GetDisplayNearestWindow(window_);
current_cursor_.SetDisplayInfo(display);
UpdateCursorIfOverSelf();
}
@@ -1042,8 +1043,9 @@ bool RenderWidgetHostViewAura::UsesNativeWindowFrame() const {
void RenderWidgetHostViewAura::UpdateMouseLockRegion() {
RECT window_rect =
- gfx::Screen::GetScreen()->DIPToScreenRectInWindow(
- window_, window_->GetBoundsInScreen()).ToRECT();
+ display::Screen::GetScreen()
+ ->DIPToScreenRectInWindow(window_, window_->GetBoundsInScreen())
+ .ToRECT();
::ClipCursor(&window_rect);
}
@@ -1137,7 +1139,8 @@ gfx::Rect RenderWidgetHostViewAura::GetBoundsInRootWindow() {
}
}
- bounds = gfx::Screen::GetScreen()->ScreenToDIPRectInWindow(top_level, bounds);
+ bounds =
+ display::Screen::GetScreen()->ScreenToDIPRectInWindow(top_level, bounds);
#endif
return bounds;
@@ -1690,20 +1693,19 @@ void RenderWidgetHostViewAura::SetEditCommandForNextKeyEvent(int command_id) {
}
////////////////////////////////////////////////////////////////////////////////
-// RenderWidgetHostViewAura, gfx::DisplayObserver implementation:
+// RenderWidgetHostViewAura, display::DisplayObserver implementation:
void RenderWidgetHostViewAura::OnDisplayAdded(
- const gfx::Display& new_display) {
-}
+ const display::Display& new_display) {}
void RenderWidgetHostViewAura::OnDisplayRemoved(
- const gfx::Display& old_display) {
-}
+ const display::Display& old_display) {}
void RenderWidgetHostViewAura::OnDisplayMetricsChanged(
- const gfx::Display& display, uint32_t metrics) {
+ const display::Display& display,
+ uint32_t metrics) {
// The screen info should be updated regardless of the metric change.
- gfx::Screen* screen = gfx::Screen::GetScreen();
+ display::Screen* screen = display::Screen::GetScreen();
if (display.id() == screen->GetDisplayNearestWindow(window_).id()) {
UpdateScreenInfo(window_);
current_cursor_.SetDisplayInfo(display);
@@ -1774,8 +1776,8 @@ void RenderWidgetHostViewAura::OnDeviceScaleFactorChanged(
UpdateScreenInfo(window_);
device_scale_factor_ = device_scale_factor;
- const gfx::Display display = gfx::Screen::GetScreen()->
- GetDisplayNearestWindow(window_);
+ const display::Display display =
+ display::Screen::GetScreen()->GetDisplayNearestWindow(window_);
DCHECK_EQ(device_scale_factor, display.device_scale_factor());
current_cursor_.SetDisplayInfo(display);
SnapToPhysicalPixelBoundary();
@@ -2304,7 +2306,7 @@ void RenderWidgetHostViewAura::OnWindowFocused(aura::Window* gained_focus,
// If we lose the focus while fullscreen, close the window; Pepper Flash
// won't do it for us (unlike NPAPI Flash). However, we do not close the
// window if we lose the focus to a window on another display.
- gfx::Screen* screen = gfx::Screen::GetScreen();
+ display::Screen* screen = display::Screen::GetScreen();
bool focusing_other_display =
gained_focus && screen->GetNumDisplays() > 1 &&
(screen->GetDisplayNearestWindow(window_).id() !=
@@ -2362,7 +2364,7 @@ RenderWidgetHostViewAura::~RenderWidgetHostViewAura() {
window_->GetHost()->RemoveObserver(this);
UnlockMouse();
aura::client::SetTooltipText(window_, NULL);
- gfx::Screen::GetScreen()->RemoveObserver(this);
+ display::Screen::GetScreen()->RemoveObserver(this);
// This call is usually no-op since |this| object is already removed from
// the Aura root window and we don't have a way to get an input method
@@ -2398,7 +2400,7 @@ void RenderWidgetHostViewAura::CreateAuraWindow() {
aura::client::SetActivationDelegate(window_, this);
aura::client::SetFocusChangeObserver(window_, this);
window_->set_layer_owner_delegate(delegated_frame_host_.get());
- gfx::Screen::GetScreen()->AddObserver(this);
+ display::Screen::GetScreen()->AddObserver(this);
}
void RenderWidgetHostViewAura::UpdateCursorIfOverSelf() {
@@ -2409,7 +2411,7 @@ void RenderWidgetHostViewAura::UpdateCursorIfOverSelf() {
if (!root_window)
return;
- gfx::Screen* screen = gfx::Screen::GetScreen();
+ display::Screen* screen = display::Screen::GetScreen();
DCHECK(screen);
gfx::Point cursor_screen_point = screen->GetCursorScreenPoint();

Powered by Google App Engine
This is Rietveld 408576698