[Findit] Updating extractors.py to account for new compile failure stdio format

appengine/findit/waterfall/test/extractors_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import textwrap
 
 from waterfall import extractors
 from waterfall.extractor import Extractor
 from waterfall.test import wf_testcase
 
 
 class ExtractorsTest(wf_testcase.WaterfallTestCase):
 
   def _RunTest(self, failure_log, extractor_class, expected_signal_json,
                bot='builder1', master='master1'):
     signal = extractor_class().Extract(
         failure_log, 'suite.test', 'step', bot, master)
+
     self.assertEqual(expected_signal_json, signal.ToDict())
 
   def testGeneralExtractor(self):
     failure_log = textwrap.dedent("""
         blabla WARNING: bla bla a/b/c.cc:20
 
         blabla d/e/f.cc:30
         blabla""")
     expected_signal_json = {
         'files': {
@@ skipping 250 matching lines @@
         'keywords': {}
     }
 
     self._RunTest(
         failure_log, extractors.GeneralExtractor, expected_signal_json)
 
   def testCompileStepExtractor(self):
     failure_log = textwrap.dedent("""
         [1832/2467 | 117.498] CXX obj/a/b/test.file.o
         blabla...
-        FAILED: /b/build/goma/gomacc ... ../../a/b/c.cc ... obj/a/b/test.c.o
+        FAILED: obj/a/b/test.c.o
+        /b/build/goma/gomacc blabla ... -c ../../a/b/c.cc -o obj/a/b/test.c.o
         ../../a/b/c.cc:307:44: error: no member 'kEnableExtensionInfoDialog' ...
         1 error generated.
         x/y/not_in_signal.cc
-        FAILED: /b/build/goma/gomacc ... ../../a/b/x.cc ... obj/a/b/test.c.o
+        FAILED: obj/a/b/test.d.o
+        /b/build/goma/gomacc blabla ... -c ../../a/b/d.cc -o obj/a/b/test.d.o
         ../../a/b/d.cc:123:44: error: no member 'kEnableExtensionInfoDialog' ...
         blabla...
-        FAILED: /b/build/goma/gomacc ... ../../a/b/x.cc ... obj/a/b/test.c.o
+        1 error generated.
+        FAILED: obj/a/b/test.e.o
+        /b/build/goma/gomacc ... ../../a/b/e.cc ... obj/a/b/test.e.o
         ../../a/b/e.cc:79:44: error: no member 'kEnableExtensionInfoDialog' ...
         blabla...
         ninja: build stopped: subcommand failed.
 
         /b/build/goma/goma_ctl.sh stat
         blabla...""")
     expected_signal_json = {
         'files': {
             'a/b/c.cc': [307],
             'a/b/d.cc': [123],
             'a/b/e.cc': [79]
         },
         'keywords': {}
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json)
 
   def testCompileStepExtractorExtractFailedCompileTargetsLinux(self):
     failure_log = textwrap.dedent("""
         [1832/2467 | 117.498] CXX obj/a/b/test.file.o
         blabla...
-        FAILED: /b/build/goma/gomacc ... -c ../../a/b/c.cc -o obj/a/b/c.o
+        FAILED: obj/a/b/c.o
+        /b/build/goma/gomacc ... -c ../../a/b/c.cc -o obj/a/b/c.o
         ../../a/b/c.cc:307:44: error: no member 'kEnableExtensionInfoDialog' ...
         1 error generated.
         x/y/not_in_signal.cc
-        FAILED: /b/build/goma/gomacc ... -c ../../a/b/x.cc -o obj/a/b/x.o
+        FAILED: obj/a/b/x.o
+        /b/build/goma/gomacc ... -c ../../a/b/x.cc -o obj/a/b/x.o
         ../../a/b/d.cc:123:44: error: no member 'kEnableExtensionInfoDialog' ...
         blabla...
-        FAILED: /b/build/goma/gomacc ... -c ../../a/b/x.cc -o obj/a/b/x.o
-        ../../a/b/e.cc:79:44: error: no member 'kEnableExtensionInfoDialog' ...
+        1 error generated.
+        FAILED: target.exe
+        blabla -o not_this blabla gomacc ... -o target.exe
         blabla...
-        FAILED: blabla -o not_this blabla gomacc ... -o target.exe
-        blabla...
-        FAILED: blabla -o not_this blabla -c not_this.cc -o not_this.o
+        1 error generated.
+        blabla
+        FAILED: notgoma.exe
+        blabla -c blabla.c -o blabla.o
+        blabla
         ninja: build stopped: subcommand failed.
 
         /b/build/goma/goma_ctl.sh stat
         blabla...""")
     expected_signal_json = {
         'files': {
             'a/b/c.cc': [307],
             'a/b/d.cc': [123],
-            'a/b/e.cc': [79]
         },
         'keywords': {},
         'failed_targets': [
             {
                 'source': '../../a/b/c.cc',
                 'target': 'obj/a/b/c.o',
             },
             {
                 'source': '../../a/b/x.cc',
                 'target': 'obj/a/b/x.o',
@@ skipping 30 matching lines @@
         ]
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json,
         'builder2', 'master2')
 
   def testCompileStepExtractorExtractFailedLinkTargetsLinux(self):
     failure_log = textwrap.dedent("""
         [5430/5600] blabla
-        FAILED: python blabla clang++ -o a/b.nexe blabla
+        FAILED: a/b.nexe
+        python blabla clang++ -o a/b.nexe blabla
         blabla
         blabla.Error: FAILED with blabla
-        FAILED: blabla gomacc -o "target with spaces and quotes" blabla
+        FAILED: "target with spaces and quotes"
+        blabla gomacc -o "target with spaces and quotes" blabla
         ninja: build stopped: subcommand failed.""")
     expected_signal_json = {
         'files': {},
         'keywords': {},
         'failed_targets': [
             {
                 'target': 'a/b.nexe'
             },
             {
                 'target': '"target with spaces and quotes"'
             }
         ]
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json,
         'builder2', 'master2')
 
   def testCompileStepExtractorExtractFailedCompileTargetsWindows(self):
     failure_log = textwrap.dedent("""
         [4576/31353] blabla
-        FAILED: ninja blabla /c ..\\..\\a\\b\\c.cc /Foa\\b.c.obj blabla
+        FAILED: a\\b.c.obj
+        ninja blabla /c ..\\..\\a\\b\\c.cc /Foa\\b.c.obj blabla
         blabla
-        FAILED: ninja blabla /c ..\\..\\d\\e\\f.cc /Fod\\e\\f\\a.b.obj blabla
+        1 error generated.
+        FAILED: d\\e\\f\\a.b.obj
+        ninja blabla /c ..\\..\\d\\e\\f.cc /Fod\\e\\f\\a.b.obj blabla
         blabla
         ninja: build stopped: subcommand failed.""")
     expected_signal_json = {
         'files': {},
         'keywords': {},
         'failed_targets': [
             {
                 'source': '..\\..\\a\\b\\c.cc',
                 'target': 'a\\b.c.obj',
             },
             {
                 'source': '..\\..\\d\\e\\f.cc',
                 'target': 'd\\e\\f\\a.b.obj'
             },
         ]
     }
 
     self._RunTest(failure_log, extractors.CompileStepExtractor,
                   expected_signal_json, 'win_builder', 'win_master')
 
   def testCompileStepExtractorExtractFailedLinkTargetsWindows(self):
     failure_log = textwrap.dedent("""
         [11428/27088] blabla
-        FAILED: blabla link.exe /OUT:test.exe @test.exe.rsp blabla
+        FAILED: test.exe
+        blabla link.exe /OUT:test.exe @test.exe.rsp blabla
         ninja: build stopped: subcommand failed.""")
     expected_signal_json = {
         'files': {},
         'keywords': {},
         'failed_targets': [
             {
                 'target': 'test.exe'
             }
         ]
     }
@@ skipping 62 matching lines @@
 
   def testCompileStepStrictRegexForCompileFailures(self):
 
     goma_clang_prefix = (
         '/b/build/goma/gomacc '
         '../../third_party/llvm-build/Release+Asserts/bin/clang++ '
         '-MMD -MF')
     failure_log = textwrap.dedent("""
         [1832/2467 | 117.498] CXX obj/a/b/test.file.o
         blabla...
-        FAILED: %s obj/a.o.d ... -c a.c -o obj/a.o
-        blalba...
-        FAILED: %s obj/d.o.d ... -c d.c -o obj/e.o
-        blalba...
-        FAILED with 1: %s obj/f.o.d -c f.c -o obj/f.o
+        FAILED: obj/a.o
+        %s obj/a.o.d ... -c a.c -o obj/a.o
+        blabla...
+        1 error generated.
+        FAILED with 1: obj/f.o %s obj/f.o.d -c f.c -o obj/f.o
         ninja: build stopped: subcommand failed.
 
         /b/build/goma/goma_ctl.sh stat
-        blabla...""" % (
-            goma_clang_prefix, goma_clang_prefix, goma_clang_prefix))
+        blabla...""" % (goma_clang_prefix, goma_clang_prefix))
     expected_signal_json = {
-        'files': {
-            'obj/f.o': [],
-            'f.c': [],
-        },
+        'files': {},
         'keywords': {},
         'failed_targets': [
             {
                 'source': 'a.c',
                 'target': 'obj/a.o',
             },
         ]
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json)
 
   def testCompileStepStrictRegexForLinkFailures(self):
 
     goma_gcc_prefix = (
         '/b/build/slave/Linux/build/src/build/goma/client/gomacc '
         '/bla/bla/.../bin/arm-linux-androideabi-gcc')
     failure_log = textwrap.dedent("""
         [1832/2467 | 117.498] CXX obj/a/b/test.file.o
         blabla...
-        FAILED: %s -Wl,-z,now ... -o exe -Wl,--start-group obj/a.o ...
+        FAILED: obj/a.o
+        %s -Wl,-z,now ... -o exe -Wl,--start-group obj/a.o ...
         blalba...
         FAILED: cd a/b/c; python script.py a b c blabla....
         blalba...
         ninja: build stopped: subcommand failed.
 
         /b/build/goma/goma_ctl.sh stat
         blabla...""" % goma_gcc_prefix)
     expected_signal_json = {
         'files': {
         },
@@ skipping 248 matching lines @@
         # step_name: result
         '1': '1',
         '2': '2',
         '32434': '0'
     }
 
     for step_name, expected_result in cases.iteritems():
       result = extractors.ExtractSignal(
           'master', 'bot', step_name, 'test', '')
       self.assertEqual(expected_result, result)