recipe_modules/tryserver/example.expected/with_rietveld_patch_new.json - Issue 1927403003: Avoid computing patch_root in get_files_affected_by_patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/tryserver/example.expected/with_rietveld_patch_new.json

Issue 1927403003: Avoid computing patch_root in get_files_affected_by_patch. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: recipe_modules/tryserver/example.expected/with_rietveld_patch_new.json

diff --git a/recipe_modules/tryserver/example.expected/with_rietveld_patch.json b/recipe_modules/tryserver/example.expected/with_rietveld_patch_new.json

similarity index 92%

copy from recipe_modules/tryserver/example.expected/with_rietveld_patch.json

copy to recipe_modules/tryserver/example.expected/with_rietveld_patch_new.json

index 4c3bb4acb34c7f9d2d623441537bc3ef0b7515aa..b990f6cc25885d2c87e4f67b1ebb314efb3bdb7f 100644

--- a/recipe_modules/tryserver/example.expected/with_rietveld_patch.json

+++ b/recipe_modules/tryserver/example.expected/with_rietveld_patch_new.json

@@ -26,11 +26,11 @@

"--cached",

"--name-only"

- "cwd": "[SLAVE_BUILD]",

+ "cwd": "[SLAVE_BUILD]/sub/project",

"name": "git diff to analyze patch",

"stdout": "/path/to/tmp/",

"~followup_annotations": [

- "@@@STEP_LOG_LINE@files@foo.cc@@@",

+ "@@@STEP_LOG_LINE@files@sub/project/foo.cc@@@",

"@@@STEP_LOG_END@files@@@",

"@@@SET_BUILD_PROPERTY@failure_type@\"INVALID_TEST_RESULTS\"@@@",

"@@@SET_BUILD_PROPERTY@subproject_tag@\"v8\"@@@"

« no previous file with comments | « recipe_modules/tryserver/example.py ('k') | recipe_modules/tryserver/example.expected/with_wrong_patch_new.json » ('j') | no next file with comments »