Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: recipe_modules/tryserver/example.py

Issue 1927403003: Avoid computing patch_root in get_files_affected_by_patch. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Real rework + downstream Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: recipe_modules/tryserver/example.py
diff --git a/recipe_modules/tryserver/example.py b/recipe_modules/tryserver/example.py
index dead670bf8d44eb3cefc5370f3b6766092d7272d..b8cc109b083a0455b4fcb94ebf8dd5bbc5b56421 100644
--- a/recipe_modules/tryserver/example.py
+++ b/recipe_modules/tryserver/example.py
@@ -14,7 +14,8 @@ DEPS = [
def RunSteps(api):
api.path['checkout'] = api.path['slave_build']
api.tryserver.maybe_apply_issue()
- api.tryserver.get_files_affected_by_patch()
+ api.tryserver.get_files_affected_by_patch(
+ api.properties.get('test_patch_root'))
if api.tryserver.is_tryserver:
api.tryserver.set_subproject_tag('v8')
@@ -43,3 +44,10 @@ def GenTests(api):
api.properties.tryserver())
yield (api.test('with_wrong_patch') + api.platform('win', 32))
+
+
+ yield (api.test('with_rietveld_patch_new') +
+ api.properties.tryserver(test_patch_root='sub/project'))
+
+ yield (api.test('with_wrong_patch_new') + api.platform('win', 32) +
+ api.properties(test_patch_root='sub/project'))
Michael Achenbach 2016/05/02 06:44:32 Will the patch root also on windows be passed with
tandrii(chromium) 2016/05/02 09:56:36 hm, good point! Done.

Powered by Google App Engine
This is Rietveld 408576698