Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: recipe_modules/tryserver/example.py

Issue 1927403003: Avoid computing patch_root in get_files_affected_by_patch. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'recipe_engine/path', 6 'recipe_engine/path',
7 'recipe_engine/platform', 7 'recipe_engine/platform',
8 'recipe_engine/properties', 8 'recipe_engine/properties',
9 'recipe_engine/python', 9 'recipe_engine/python',
10 'tryserver', 10 'tryserver',
11 ] 11 ]
12 12
13 13
14 def RunSteps(api): 14 def RunSteps(api):
15 api.path['checkout'] = api.path['slave_build'] 15 api.path['checkout'] = api.path['slave_build']
16 api.tryserver.maybe_apply_issue() 16 api.tryserver.maybe_apply_issue()
17 api.tryserver.get_files_affected_by_patch() 17 api.tryserver.get_files_affected_by_patch(
18 api.properties.get('test_patch_root'))
18 19
19 if api.tryserver.is_tryserver: 20 if api.tryserver.is_tryserver:
20 api.tryserver.set_subproject_tag('v8') 21 api.tryserver.set_subproject_tag('v8')
21 22
22 api.tryserver.set_patch_failure_tryjob_result() 23 api.tryserver.set_patch_failure_tryjob_result()
23 api.tryserver.set_compile_failure_tryjob_result() 24 api.tryserver.set_compile_failure_tryjob_result()
24 api.tryserver.set_test_failure_tryjob_result() 25 api.tryserver.set_test_failure_tryjob_result()
25 api.tryserver.set_invalid_test_results_tryjob_result() 26 api.tryserver.set_invalid_test_results_tryjob_result()
26 27
27 with api.tryserver.set_failure_hash(): 28 with api.tryserver.set_failure_hash():
28 api.python.failing_step('fail', 'foo') 29 api.python.failing_step('fail', 'foo')
29 30
30 31
31 def GenTests(api): 32 def GenTests(api):
32 yield (api.test('with_svn_patch') + 33 yield (api.test('with_svn_patch') +
33 api.properties(patch_url='svn://checkout.url')) 34 api.properties(patch_url='svn://checkout.url'))
34 35
35 yield (api.test('with_git_patch') + 36 yield (api.test('with_git_patch') +
36 api.properties( 37 api.properties(
37 patch_storage='git', 38 patch_storage='git',
38 patch_project='v8', 39 patch_project='v8',
39 patch_repo_url='http://patch.url/', 40 patch_repo_url='http://patch.url/',
40 patch_ref='johndoe#123.diff')) 41 patch_ref='johndoe#123.diff'))
41 42
42 yield (api.test('with_rietveld_patch') + 43 yield (api.test('with_rietveld_patch') +
43 api.properties.tryserver()) 44 api.properties.tryserver())
44 45
45 yield (api.test('with_wrong_patch') + api.platform('win', 32)) 46 yield (api.test('with_wrong_patch') + api.platform('win', 32))
47
48
49 yield (api.test('with_rietveld_patch_new') +
50 api.properties.tryserver(test_patch_root='sub/project'))
51
52 yield (api.test('with_wrong_patch_new') + api.platform('win', 32) +
53 api.properties(test_patch_root='sub\\project'))
OLDNEW
« no previous file with comments | « recipe_modules/tryserver/api.py ('k') | recipe_modules/tryserver/example.expected/with_rietveld_patch_new.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698