Avoid computing patch_root in get_files_affected_by_patch.

recipe_modules/tryserver/api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import contextlib
 import hashlib
 
 from recipe_engine import recipe_api
 
 
@@ skipping 130 matching lines @@
           self.m.rietveld.calculate_issue_root(),
           authentication=authentication)
     elif storage == PATCH_STORAGE_SVN:
       return self.apply_from_svn(cwd)
     elif storage == PATCH_STORAGE_GIT:
       return self.apply_from_git(cwd)
     else:
       # Since this method is "maybe", we don't raise an Exception.
       pass
 
-  def get_files_affected_by_patch(self):
+  def get_files_affected_by_patch(self, patch_root=None):
+    """Returns list of paths to files affected by the patch.
+
+    Argument:
+      patch_root: path relative to api.path['root'], usually obtained from
+        api.gclient.calculate_patch_root(patch_project)
+
+    Returned paths will be relative to to patch_root.
+
+    TODO(tandrii): remove this doc.
+    Unless you use patch_root=None, in which case old behavior is used
+    which returns paths relative to checkout aka solution[0].name.
+    """
+    # patch_root must be set! None is for backwards compataibility and will be
+    # removed.
+    if patch_root is None:
+      return self._old_get_files_affected_by_patch()
+    step_result = self.m.git('diff', '--cached', '--name-only',
+                             cwd=self.m.path['slave_build'].join(patch_root),
+                             name='git diff to analyze patch',
+                             stdout=self.m.raw_io.output(),
+                             step_test_data=lambda:
+                               self.m.raw_io.test_api.stream_output('foo.cc'))
+    paths = [self.m.path.join(patch_root, p) for p in
+             step_result.stdout.split()]
+    if self.m.platform.is_win:

[Michael Achenbach, 2016/05/02 06:44:32]

nit: Some tabs sneaked in?

[tandrii(chromium), 2016/05/02 09:56:36]

Done.

+                        # Looks like "analyze" wants POSIX slashes even on Windows (since git
+                        # uses that format even on Windows).
+      paths = [path.replace('\\', '/') for path in paths]
+    step_result.presentation.logs['files'] = paths
+    return paths
+
+
+  def _old_get_files_affected_by_patch(self):
     git_diff_kwargs = {}
     issue_root = self.m.rietveld.calculate_issue_root()
     if issue_root:
       git_diff_kwargs['cwd'] = self.m.path['checkout'].join(issue_root)
     step_result = self.m.git('diff', '--cached', '--name-only',
                              name='git diff to analyze patch',
                              stdout=self.m.raw_io.output(),
                              step_test_data=lambda:
                                self.m.raw_io.test_api.stream_output('foo.cc'),
                              **git_diff_kwargs)
@@ skipping 76 matching lines @@
       self.add_failure_reason(e.reason)
 
       failure_hash = hashlib.sha1()
       failure_hash.update(self.m.json.dumps(self._failure_reasons))
 
       step_result = self.m.step.active_result
       step_result.presentation.properties['failure_hash'] = \
           failure_hash.hexdigest()
 
       raise