Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1927363002: DevTools: add LRM character to correct search placeholder text (Closed)

Created:
4 years, 7 months ago by luoe
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add LRM character to correct search placeholder text For more info on this particular RTL behavior, see: http://stackoverflow.com/questions/5801820/how-to-solve-bidi-bracket-issues BUG=607421 Committed: https://crrev.com/b7ebd042d13e4fdc1d6466846baf5cc431b2a557 Cr-Commit-Position: refs/heads/master@{#390693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
lushnikov
lgtm
4 years, 7 months ago (2016-04-29 16:50:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927363002/1
4 years, 7 months ago (2016-04-29 16:50:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 17:58:07 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:27:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7ebd042d13e4fdc1d6466846baf5cc431b2a557
Cr-Commit-Position: refs/heads/master@{#390693}

Powered by Google App Engine
This is Rietveld 408576698