Issue 1927353002: Use lazy static fields when overriding static getters or setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1927353002: Use lazy static fields when overriding static getters or setters. (Closed)

Created:
4 years, 7 months ago by Harry Terkelsen

Modified:
4 years, 7 months ago

Reviewers:
vsm, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -31 lines)			Patch
M	lib/src/compiler/code_generator.dart	View	1	5 chunks	+31 lines, -19 lines	0 comments	Download
M	lib/src/compiler/js_field_storage.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A +	test/codegen/language/static_field_override1_test.dart	View		1 chunk	+11 lines, -4 lines	0 comments	Download
A +	test/codegen/language/static_field_override2_test.dart	View		1 chunk	+12 lines, -4 lines	0 comments	Download
A +	test/codegen/language/static_field_override3_test.dart	View		1 chunk	+11 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Harry Terkelsen

4 years, 7 months ago (2016-04-28 22:42:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
bf1ca479c77187208abae5f6a87239d43ba3deb6 (presubmit successful).