Conditionally set enable_ipc_fuzzer for GN builds.

Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build or
official build, and is for a supported platform.

BUG=607671
Committed: https://crrev.com/30a7054a8304844de0aa40d38cb08715bb867f6c
Cr-Commit-Position: refs/heads/master@{#390972}

[Oliver Chang, 2016-04-28 20:40:32]

Description was changed from

==========
Set enable_ipc_fuzzer=true for GN builds.

This is only set if the build is not a component build and not an
official build.

BUG=607671
==========

to

==========
Set enable_ipc_fuzzer=true for non-component GN builds.

This is only set if the build is not a component build and not an
official build.

BUG=607671
==========

[Oliver Chang, 2016-04-28 20:52:15]

Description was changed from

==========
Set enable_ipc_fuzzer=true for non-component GN builds.

This is only set if the build is not a component build and not an
official build.

BUG=607671
==========

to

==========
Set enable_ipc_fuzzer=true for non-component GN builds.

This is only set if the build is not a component build and not an
official build.

Also fixes a missing DEP in ipc_message_lib.

BUG=607671
==========

[Oliver Chang, 2016-04-28 20:54:25]

Description was changed from

==========
Set enable_ipc_fuzzer=true for non-component GN builds.

This is only set if the build is not a component build and not an
official build.

Also fixes a missing DEP in ipc_message_lib.

BUG=607671
==========

to

==========
Set enable_ipc_fuzzer=true for (!component && !official) GN builds.

This is only set if the build is not a component build and not an
official build.

Also fixes a missing DEP in ipc_message_lib.

BUG=607671
==========

[Oliver Chang, 2016-04-28 22:24:32]

Description was changed from

==========
Set enable_ipc_fuzzer=true for (!component && !official) GN builds.

This is only set if the build is not a component build and not an
official build.

Also fixes a missing DEP in ipc_message_lib.

BUG=607671
==========

to

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build, 
official build, or a chromecast build.

Also fixes a missing DEP in ipc_message_lib.

BUG=607671
==========

[Oliver Chang, 2016-04-28 22:29:32]

Description was changed from

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build, 
official build, or a chromecast build.

Also fixes a missing DEP in ipc_message_lib.

BUG=607671
==========

to

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build, 
official build, and for a supported platform.

Also fixes a missing DEP in ipc_message_lib.

BUG=607671
==========

[Oliver Chang, 2016-04-28 22:33:03]

Patchset #3 (id:40001) has been deleted

[Oliver Chang, 2016-04-28 22:34:14]

Description was changed from

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build, 
official build, and for a supported platform.

Also fixes a missing DEP in ipc_message_lib.

BUG=607671
==========

to

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build or 
official build, and is for a supported platform.

Also fixes a missing DEP in ipc_message_lib.

BUG=607671
==========

[Oliver Chang, 2016-04-28 22:38:25]

Patchset #4 (id:80001) has been deleted

[Oliver Chang, 2016-04-29 15:02:14]

ochang@chromium.org changed reviewers:
+ mbarbella@chromium.org, thakis@chromium.org, tsepez@chromium.org

[Oliver Chang, 2016-04-29 15:17:09]

ptal.

As discussed with Nico with an email thread, this is so that existing bots get
ipc fuzzer build coverage without having to add new bots for them.

[Nico, 2016-04-29 15:19:42]

The CL description is a bit light on details. tsepez, this will have the effect
of making the defined(ENABLE_IPC_FUZZER) checks in ipc true in regular
non-component (non-production) builds:
https://code.google.com/p/chromium/codesearch#search/&q=defined%5C(enable_ipc...

You're here for an ipc/OWNERS review to check if that looks fine to you.

ochang, were you able to track down why the ENABLE_IPC_FUZZER define exists in
the first place? Who added it? When? Why?

[Oliver Chang, 2016-04-29 15:22:25]

On 2016/04/29 15:19:42, Nico wrote:
> The CL description is a bit light on details. tsepez, this will have the
effect
> of making the defined(ENABLE_IPC_FUZZER) checks in ipc true in regular
> non-component (non-production) builds:
>
https://code.google.com/p/chromium/codesearch#search/&q=defined%5C(enable_ipc...
> 
> You're here for an ipc/OWNERS review to check if that looks fine to you.
> 
> ochang, were you able to track down why the ENABLE_IPC_FUZZER define exists in
> the first place? Who added it? When? Why?

tsepez and mbarbella are the owners of ipc fuzzer, so they should know the
details. mbarbella said that it was so that the --ipc-dump-directory flag isn't
exposed for a production build, but the !is_official_build condition should take
care of that here.

[Oliver Chang, 2016-04-29 15:27:44]

On 2016/04/29 15:22:25, Oliver Chang wrote:
> On 2016/04/29 15:19:42, Nico wrote:
> > The CL description is a bit light on details. tsepez, this will have the
> effect
> > of making the defined(ENABLE_IPC_FUZZER) checks in ipc true in regular
> > non-component (non-production) builds:
> >
>
https://code.google.com/p/chromium/codesearch#search/&q=defined%5C(enable_ipc...
> > 
> > You're here for an ipc/OWNERS review to check if that looks fine to you.
> > 
> > ochang, were you able to track down why the ENABLE_IPC_FUZZER define exists
in
> > the first place? Who added it? When? Why?
> 
> tsepez and mbarbella are the owners of ipc fuzzer, so they should know the
> details. mbarbella said that it was so that the --ipc-dump-directory flag
isn't
> exposed for a production build, but the !is_official_build condition should
take
> care of that here.

(Marty was also the one who added this flag:
https://codereview.chromium.org/975903002)

[Martin Barbella, 2016-04-29 17:19:59]

On 2016/04/29 15:27:44, Oliver Chang wrote:
> On 2016/04/29 15:22:25, Oliver Chang wrote:
> > On 2016/04/29 15:19:42, Nico wrote:
> > > The CL description is a bit light on details. tsepez, this will have the
> > effect
> > > of making the defined(ENABLE_IPC_FUZZER) checks in ipc true in regular
> > > non-component (non-production) builds:
> > >
> >
>
https://code.google.com/p/chromium/codesearch#search/&q=defined%5C(enable_ipc...
> > > 
> > > You're here for an ipc/OWNERS review to check if that looks fine to you.
> > > 
> > > ochang, were you able to track down why the ENABLE_IPC_FUZZER define
exists
> in
> > > the first place? Who added it? When? Why?
> > 
> > tsepez and mbarbella are the owners of ipc fuzzer, so they should know the
> > details. mbarbella said that it was so that the --ipc-dump-directory flag
> isn't
> > exposed for a production build, but the !is_official_build condition should
> take
> > care of that here.
> 
> (Marty was also the one who added this flag:
> https://codereview.chromium.org/975903002)

It's also going to be fairly slow when building with certain sanitizers. Oliver,
can we keep these disabled by default as well until we've had time to
investigate a bit more? I know that MSan takes several hours to build fuzzer.cc,
and suspect that UBSan would have similar problems.

[Oliver Chang, 2016-04-29 17:22:13]

On 2016/04/29 17:19:59, Martin Barbella wrote:
> On 2016/04/29 15:27:44, Oliver Chang wrote:
> > On 2016/04/29 15:22:25, Oliver Chang wrote:
> > > On 2016/04/29 15:19:42, Nico wrote:
> > > > The CL description is a bit light on details. tsepez, this will have the
> > > effect
> > > > of making the defined(ENABLE_IPC_FUZZER) checks in ipc true in regular
> > > > non-component (non-production) builds:
> > > >
> > >
> >
>
https://code.google.com/p/chromium/codesearch#search/&q=defined%5C(enable_ipc...
> > > > 
> > > > You're here for an ipc/OWNERS review to check if that looks fine to you.
> > > > 
> > > > ochang, were you able to track down why the ENABLE_IPC_FUZZER define
> exists
> > in
> > > > the first place? Who added it? When? Why?
> > > 
> > > tsepez and mbarbella are the owners of ipc fuzzer, so they should know the
> > > details. mbarbella said that it was so that the --ipc-dump-directory flag
> > isn't
> > > exposed for a production build, but the !is_official_build condition
should
> > take
> > > care of that here.
> > 
> > (Marty was also the one who added this flag:
> > https://codereview.chromium.org/975903002)
> 
> It's also going to be fairly slow when building with certain sanitizers.
Oliver,
> can we keep these disabled by default as well until we've had time to
> investigate a bit more? I know that MSan takes several hours to build
fuzzer.cc,
> and suspect that UBSan would have similar problems.

Done! Please see the latest patchset.

[Martin Barbella, 2016-04-29 17:40:12]

lgtm

[Tom Sepez, 2016-04-29 18:16:09]

Deferring to Marty on this one.

[Nico, 2016-04-29 18:54:29]

lgtm

[Oliver Chang, 2016-04-29 18:57:07]

Description was changed from

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build or 
official build, and is for a supported platform.

Also fixes a missing DEP in ipc_message_lib.

BUG=607671
==========

to

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build or 
official build, and is for a supported platform.

BUG=607671
==========

[Oliver Chang, 2016-05-02 15:57:36]

The CQ bit was checked by ochang@chromium.org

[Oliver Chang, 2016-05-02 15:57:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
mbarbella@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1927303002/#ps180001
(title: "clang only")

[commit-bot: I haz the power, 2016-05-02 15:57:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927303002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927303002/180001

[Nico, 2016-05-02 16:18:37]

Out of interest, how hard would it be to make this work in component builds?
Most IPC messages are probably exported already, right?

[commit-bot: I haz the power, 2016-05-02 17:08:59]

Description was changed from

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build or 
official build, and is for a supported platform.

BUG=607671
==========

to

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build or 
official build, and is for a supported platform.

BUG=607671
==========

[commit-bot: I haz the power, 2016-05-02 17:09:00]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2016-05-02 17:10:50]

Description was changed from

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build or 
official build, and is for a supported platform.

BUG=607671
==========

to

==========
Conditionally set enable_ipc_fuzzer for GN builds.

This is only set if the build is not a component build or
official build, and is for a supported platform.

BUG=607671

Committed: https://crrev.com/30a7054a8304844de0aa40d38cb08715bb867f6c
Cr-Commit-Position: refs/heads/master@{#390972}
==========

[commit-bot: I haz the power, 2016-05-02 17:10:51]

Patchset 8 (id:??) landed as
https://crrev.com/30a7054a8304844de0aa40d38cb08715bb867f6c
Cr-Commit-Position: refs/heads/master@{#390972}