third_party/WebKit/LayoutTests/fast/multicol/overflowing-columns-large-gaps.html - Issue 1927283002: Improve multicol overflow rect calculation when column width is 0.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/overflowing-columns-large-gaps.html

Issue 1927283002: Improve multicol overflow rect calculation when column width is 0. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/check-layout.js"></script>

	3 <p>There should be a horizontal scrollbar below.</p>

	4 <div id="container" style="overflow:auto; width:400px;" data-expected-scroll-wid th="800">
	eae 2016/05/03 13:11:28 Where are you getting 800 from? Two columns each 1 Where are you getting 800 from? Two columns each 100px wide with a gap of 200px adds up to 400 or am I missing something? mstensho (USE GERRIT) 2016/05/03 13:20:24 Yes, the specified, computed, and used value of co Show quoted text On 2016/05/03 13:11:28, eae wrote: > Where are you getting 800 from? Two columns each 100px wide with a gap of 200px > adds up to 400 or am I missing something? Yes, the specified, computed, and used value of column-count is 2, but the actual column-count will be larger, because the column height is only 40px. So we'll get ceil(200/40) = 5 columns. Used / actual column-width is 0, because the gap eats everything. Actually more than everything. :) So we get: Column 0: +0px = 0px Gap between column 0 and 1: +200px = 200px Column 1: +0px = 200px Gap between column 1 and 2: +200px = 400px Column 2: +0px = 400px Gap between column 2 and 3: +200px = 600px Column 3: +0px = 600px Gap between column 3 and 4: +200px = 800px Column 4: +0px = 800px
	5 <div style="columns:2; column-gap:200px; column-fill:auto; width:100px; heig ht:40px;">

	6 <div style="height:200px;"></div>

	7 </div>

	8 </div>

	9 <script>

	10 checkLayout("#container");

	11 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/multicol/overflowing-columns-large-gaps-expected.txt » ('j') | no next file with comments »