Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1927223002: Convert track tests from video-test.js to testharness.js based (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track tests from video-test.js to testharness.js based Cleaning up track-element*, track-id* and track-insert* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/0a7625bfcf49abfd6ac69bd90ab07dbcec41ba95 Cr-Commit-Position: refs/heads/master@{#390644}

Patch Set 1 : #

Total comments: 2

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 7 months ago (2016-04-28 19:28:39 UTC) #4
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/1927223002/diff/20001/third_party/WebKit/LayoutTests/media/track/track-id.html File third_party/WebKit/LayoutTests/media/track/track-id.html (right): https://codereview.chromium.org/1927223002/diff/20001/third_party/WebKit/LayoutTests/media/track/track-id.html#newcode24 third_party/WebKit/LayoutTests/media/track/track-id.html:24: textTrack.id = "newvalue"; I'm surprised this doesn't actually ...
4 years, 7 months ago (2016-04-29 12:42:11 UTC) #5
Srirama
https://codereview.chromium.org/1927223002/diff/20001/third_party/WebKit/LayoutTests/media/track/track-id.html File third_party/WebKit/LayoutTests/media/track/track-id.html (right): https://codereview.chromium.org/1927223002/diff/20001/third_party/WebKit/LayoutTests/media/track/track-id.html#newcode24 third_party/WebKit/LayoutTests/media/track/track-id.html:24: textTrack.id = "newvalue"; On 2016/04/29 12:42:11, Mounir Lamouri wrote: ...
4 years, 7 months ago (2016-04-29 13:21:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927223002/20001
4 years, 7 months ago (2016-04-29 13:21:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-04-29 14:25:27 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:25:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a7625bfcf49abfd6ac69bd90ab07dbcec41ba95
Cr-Commit-Position: refs/heads/master@{#390644}

Powered by Google App Engine
This is Rietveld 408576698