Add support for X11 workspaces

chrome/browser/ui/browser_window_state.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_window_state.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/macros.h"
@@ skipping 118 matching lines @@
   // Save to the session storage service, used when reloading a past session.
   // Note that we don't want to be the ones who cause lazy initialization of
   // the session service. This function gets called during initial window
   // showing, and we don't want to bring in the session service this early.
   SessionService* session_service =
       SessionServiceFactory::GetForProfileIfExisting(browser->profile());
   if (session_service)
     session_service->SetWindowBounds(browser->session_id(), bounds, show_state);
 }
 
+void SaveWindowWorkspace(const Browser* browser, const std::string& workspace) {
+  SessionService* session_service =
+      SessionServiceFactory::GetForProfileIfExisting(browser->profile());
+  if (session_service)
+    session_service->SetWindowWorkspace(browser->session_id(), workspace);
+}
+
 void GetSavedWindowBoundsAndShowState(const Browser* browser,
                                       gfx::Rect* bounds,
                                       ui::WindowShowState* show_state) {
   DCHECK(browser);
   DCHECK(bounds);
   DCHECK(show_state);
   *bounds = browser->override_bounds();
   WindowSizer::GetBrowserWindowBoundsAndShowState(browser->app_name(),
                                                   *bounds,
                                                   browser,
@@ skipping 12 matching lines @@
   }
   if (parsed_command_line.HasSwitch(switches::kWindowPosition)) {
     std::string str =
         parsed_command_line.GetSwitchValueASCII(switches::kWindowPosition);
     int x, y;
     if (ParseCommaSeparatedIntegers(str, &x, &y))
       bounds->set_origin(gfx::Point(x, y));
   }
 }
 
+void GetSavedWindowWorkspace(const Browser* browser, std::string* workspace) {

[sky, 2016/05/03 17:40:52]

Why do we need this function? Can't callers call browser->initial_workspace()
directly?

[Tom (Use chromium acct), 2016/05/03 19:38:39]

I completed the TODO in the comment here.  Should we keep this function now that
it actually does something useful? (It still only gets called in one place)

[sky, 2016/05/03 20:11:59]

I don't see the point in this function, so I say nuke it.

[Tom (Use chromium acct), 2016/05/03 20:27:58]

Done.

+  DCHECK(browser);
+  DCHECK(workspace);
+  *workspace = browser->initial_workspace();
+
+  // TODO(thomasanderson): add command line option for initial workspace
+}
+
 }  // namespace chrome