Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1927203002: Start to add assembler tests for DBC (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : #

Patch Set 4 : Add more tests #

Patch Set 5 : Add compare and branch tests #

Patch Set 6 : Add double strict equal tests #

Total comments: 2

Patch Set 7 : Add -NonSmi tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+617 lines, -2 lines) Patch
A runtime/vm/assembler_dbc_test.cc View 1 2 3 4 5 6 1 chunk +600 lines, -0 lines 0 comments Download
M runtime/vm/unit_test.h View 1 2 3 2 chunks +16 lines, -2 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 7 months ago (2016-04-28 19:24:38 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/1927203002/diff/100001/runtime/vm/assembler_dbc_test.cc File runtime/vm/assembler_dbc_test.cc (right): https://codereview.chromium.org/1927203002/diff/100001/runtime/vm/assembler_dbc_test.cc#newcode37 runtime/vm/assembler_dbc_test.cc:37: // TODO(zra): Test fail over to the ...
4 years, 7 months ago (2016-04-29 05:57:53 UTC) #3
zra
https://codereview.chromium.org/1927203002/diff/100001/runtime/vm/assembler_dbc_test.cc File runtime/vm/assembler_dbc_test.cc (right): https://codereview.chromium.org/1927203002/diff/100001/runtime/vm/assembler_dbc_test.cc#newcode37 runtime/vm/assembler_dbc_test.cc:37: // TODO(zra): Test fail over to the runtime call. ...
4 years, 7 months ago (2016-04-29 16:08:57 UTC) #4
zra
4 years, 7 months ago (2016-04-29 16:09:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
7c9fe494950508ae268f3eb1a8ed40c336b91ee6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698