Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1927133003: Check includes in src/chromeos (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
stevenjb, brettw
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check includes in src/chromeos BUG=None Committed: https://crrev.com/3f959fa8de40de8a883a2194c4f7b9665e8f2b17 Cr-Commit-Position: refs/heads/master@{#391008}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/BUILD.gn View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
oshima
4 years, 7 months ago (2016-04-29 17:41:12 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927133003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927133003/40001
4 years, 7 months ago (2016-04-29 17:41:30 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927133003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927133003/60001
4 years, 7 months ago (2016-04-29 17:42:57 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 19:04:35 UTC) #12
stevenjb
lgtm
4 years, 7 months ago (2016-04-29 19:38:17 UTC) #13
oshima
brettw@ -> .gn
4 years, 7 months ago (2016-04-29 19:53:02 UTC) #15
brettw
lgtm
4 years, 7 months ago (2016-05-02 17:11:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927133003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927133003/60001
4 years, 7 months ago (2016-05-02 17:31:02 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-05-02 18:43:13 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 18:44:56 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f959fa8de40de8a883a2194c4f7b9665e8f2b17
Cr-Commit-Position: refs/heads/master@{#391008}

Powered by Google App Engine
This is Rietveld 408576698